Fix build issue with Fhir.Metrics 1.3.1 nullability annotations#3229
Merged
alexzautke merged 3 commits intodependabot/nuget/src/Benchmarks/multi-d164b175f3from Jul 28, 2025
Merged
Conversation
Co-authored-by: alexzautke <548617+alexzautke@users.noreply.github.com>
Co-authored-by: alexzautke <548617+alexzautke@users.noreply.github.com>
alexzautke
approved these changes
Jul 28, 2025
Copilot
AI
changed the title
[WIP] Fix build issue in #3227
Fix build issue with Fhir.Metrics 1.3.1 nullability annotations
Jul 28, 2025
88bf866
into
dependabot/nuget/src/Benchmarks/multi-d164b175f3
3 of 5 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the build errors that occur when updating the dependencies in PR #3227, specifically after updating Fhir.Metrics from 1.3.0 to 1.3.1.
Issue
The build fails with nullability mismatch errors in
Ucum.cs:Root Cause
The Fhir.Metrics 1.3.1 update introduced stricter nullability annotations. The METRIC_SERVICE methods (
TryCanonicalize,TryMultiply,TryDivide) now return tuples with nullablestring?for the codesystem parameter, but the localquantityFromTuplemethod expected a non-nullablestring.Solution
Updated the
quantityFromTuplemethod signature to accept nullablestring?for the codesystem parameter:This minimal change maintains backward compatibility while resolving the nullability mismatch.
Verification
Fixes #3228.
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.