Skip to content

Improve handling for gamedata user error#64

Merged
nosoop merged 3 commits intomasterfrom
pebkac
May 26, 2025
Merged

Improve handling for gamedata user error#64
nosoop merged 3 commits intomasterfrom
pebkac

Conversation

@nosoop
Copy link
Copy Markdown
Collaborator

@nosoop nosoop commented May 17, 2025

Should properly address #58.

If we ever support 64-bit just remove the corresponding PluginFailMessage entries. :^)

@nosoop
Copy link
Copy Markdown
Collaborator Author

nosoop commented May 17, 2025

Compiles and tests fine in Windows x64; just waiting on AM to come back up for the workflow's sake.

@nosoop
Copy link
Copy Markdown
Collaborator Author

nosoop commented May 17, 2025

Forgot to rebase. Really fixed now.

@nosoop
Copy link
Copy Markdown
Collaborator Author

nosoop commented May 17, 2025

Adjusted based on feedback.

it may be fine to just trust that loadgameconfig handles fileexists already

okay so both windows / linux do report missing file on initial load

[SM] Error parsing gameconfig file "addons\sourcemod\gamedata\tf2.attributes.txt":
[SM] Error 1 on line 0, col 0: Stream failed to open
[SM] Exception reported: Unable to open tf2.attributes: File could not be opened: The system cannot find the file specified.

but unloading + loading afterwards with the file still missing does

[SM] Exception reported: Could not initialize call to CEconItemSchema::GetItemDefinition

@nosoop
Copy link
Copy Markdown
Collaborator Author

nosoop commented May 26, 2025

LGTM. We ball

@nosoop nosoop merged commit 6cbccd1 into master May 26, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant