fix(components): promise.all failed silently when loading MCP tools#4750
Merged
HenryHengZJ merged 4 commits intoFlowiseAI:mainfrom Jul 9, 2025
Merged
Conversation
Contributor
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When some of tools in custom MCP server have incorrect schema definition, Flowise failed to load that MCP server with zero error indication.
Linked to Issue #4749
The root cause is when there is any rejected promise the
Promise.all()will abort all remaining result and fall silently.This PR replace
Promise.all()withPromise.allSettled(), this change provides two benefits: