Skip to content

Conversation

@HenryHengZJ
Copy link
Contributor

  • Implemented a validation function to check for banned commands and dangerous patterns.
  • Added checks for potential shell injection attempts in command and arguments.
  • Security validation is conditionally enabled based on environment variable CUSTOM_MCP_SECURITY_CHECK.

…dangerous patterns.

- Added checks for potential shell injection attempts in command and arguments.
- Security validation is conditionally enabled based on environment variable CUSTOM_MCP_SECURITY_CHECK.
…upergatewayMCP. Added checks for banned commands, dangerous patterns, and potential shell injection attempts. Security validation is conditionally enabled based on the CUSTOM_MCP_SECURITY_CHECK environment variable.
@HenryHengZJ HenryHengZJ merged commit e8dac20 into main Jul 30, 2025
2 checks passed
@aiac
Copy link

aiac commented Aug 14, 2025

Does it solve https://nvd.nist.gov/vuln/detail/CVE-2025-8943?

@Frentzen
Copy link

Frentzen commented Aug 17, 2025

Hi team,

After analyzing the stable version (main branch), I noticed that the security function introduced through the PR to mitigate the vulnerability, validateMCPServerSecurity, is no longer present in the current release.

Instead, a new function called validateArgsForLocalFileAccess has been introduced, but it does not provide proper validation against remote code execution (RCE).

When testing the latest version against the available exploits (using Docker Compose to deploy a local instance), it appears that the application remains vulnerable to the same CVE.

image image

Are you planning to release a new patch for this vulnerability, or is this the intended behavior?

For context, I enabled the CUSTOM_MCP_SECURITY_CHECK flag during my analysis.

image

Edit: I think I found the PR that removed the security checks: https://github.com/FlowiseAI/Flowise/pull/5003/commits

@HenryHengZJ
Copy link
Contributor Author

This PR #5232 will enable security check by default, and here's the recommended settings when deployed on cloud in production:

# Enable security validation (default)
CUSTOM_MCP_SECURITY_CHECK=true

# Use SSE protocol for better security
CUSTOM_MCP_PROTOCOL=sse

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants