Skip to content

Chore/Remove Deprecated File Path Unstructured #5478

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
HenryHengZJ merged 2 commits into from
Nov 15, 2025
Merged

Chore/Remove Deprecated File Path Unstructured #5478

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8948d13
Refactor UnstructuredFile and UnstructuredFolder loaders to remove de…
HenryHengZJ Nov 15, 2025
7bfe86b
Update UnstructuredFolder.ts
HenryHengZJ Nov 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
49 changes: 2 additions & 47 deletions packages/components/nodes/documentloaders/Unstructured/UnstructuredFile.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,15 +4,11 @@ import {
UnstructuredLoaderOptions,
UnstructuredLoaderStrategy,
SkipInferTableTypes,
HiResModelName,
UnstructuredLoader as LCUnstructuredLoader
HiResModelName
} from '@langchain/community/document_loaders/fs/unstructured'
import { getCredentialData, getCredentialParam, handleEscapeCharacters } from '../../../src/utils'
import { getFileFromStorage, INodeOutputsValue } from '../../../src'
import { UnstructuredLoader } from './Unstructured'
import { isPathTraversal, isUnsafeFilePath } from '../../../src/validator'
import sanitize from 'sanitize-filename'
import path from 'path'

class UnstructuredFile_DocumentLoaders implements INode {
label: string
Expand Down Expand Up @@ -44,17 +40,6 @@ class UnstructuredFile_DocumentLoaders implements INode {
optional: true
}
this.inputs = [
/** Deprecated
{
label: 'File Path',
name: 'filePath',
type: 'string',
placeholder: '',
optional: true,
warning:
'Use the File Upload instead of File path. If file is uploaded, this path is ignored. Path will be deprecated in future releases.'
},
*/
{
label: 'Files Upload',
name: 'fileObject',
Expand Down Expand Up @@ -455,7 +440,6 @@ class UnstructuredFile_DocumentLoaders implements INode {
}

async init(nodeData: INodeData, _: string, options: ICommonObject): Promise<any> {
const filePath = nodeData.inputs?.filePath as string
const unstructuredAPIUrl = nodeData.inputs?.unstructuredAPIUrl as string
const strategy = nodeData.inputs?.strategy as UnstructuredLoaderStrategy
const encoding = nodeData.inputs?.encoding as string
Expand Down Expand Up @@ -560,37 +544,8 @@ class UnstructuredFile_DocumentLoaders implements INode {
docs.push(...loaderDocs)
}
}
} else if (filePath) {
if (!filePath || typeof filePath !== 'string') {
throw new Error('Invalid file path format')
}

if (isPathTraversal(filePath) || isUnsafeFilePath(filePath)) {
throw new Error('Invalid path characters detected in filePath - path traversal not allowed')
}

const parsedPath = path.parse(filePath)
const sanitizedFilename = sanitize(parsedPath.base)

if (!sanitizedFilename || sanitizedFilename.trim() === '') {
throw new Error('Invalid filename after sanitization')
}

const sanitizedFilePath = path.join(parsedPath.dir, sanitizedFilename)

if (!path.isAbsolute(sanitizedFilePath)) {
throw new Error('File path must be absolute')
}

if (sanitizedFilePath.includes('..')) {
throw new Error('Invalid file path - directory traversal not allowed')
}

const loader = new LCUnstructuredLoader(sanitizedFilePath, obj)
const loaderDocs = await loader.load()
docs.push(...loaderDocs)
} else {
throw new Error('File path or File upload is required')
throw new Error('File upload is required')
}

if (metadata) {
Expand Down