feat: Add sorting to role assigned users table (workspaces asc, users asc)

[naaa760]

fix: #5462

• add sorting to role assigned users table

• Implements default sorting: workspaces ascending, users ascending

• Adds clickable column headers for dynamic sorting (workspace/user)

• Fixes bug: replaced undefined open variable with openAssignedUsersDrawer in useEffect

Users can now easily find role assignments without using Ctrl+F or scrolling.

[gemini-code-assist]

Summary of Changes

Hello @naaa760, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly enhances the usability of the role assigned users table by introducing comprehensive sorting capabilities. Users can now easily organize the displayed data by workspace or user, both with a default sort order and interactive column headers. Additionally, a critical bug related to the drawer's state management has been addressed, ensuring correct behavior.

Highlights

• Table Sorting: Implemented sorting functionality for the role assigned users table, allowing users to sort by workspace or user.
• Default Sorting: The table now defaults to sorting by workspaces in ascending order, then by users in ascending order.
• Dynamic Sorting: Column headers for 'Workspace' and 'User' are now clickable, enabling dynamic sorting based on user interaction.
• Bug Fix: Resolved a bug in the useEffect hook where an undefined open variable was incorrectly used; it has been replaced with openAssignedUsersDrawer.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request introduces sorting capabilities to the 'Assigned Users' table, allowing users to sort by either 'User' or 'Workspace'. This is a great usability enhancement. The implementation also includes a fix for a bug where an incorrect variable was used in a useEffect hook. The code is well-structured, but I've identified a couple of areas for improvement regarding the sorting logic's implementation for better maintainability and a potential bug related to React's list rendering.

[HenryHengZJ]

thanks!