fix: OpenAI Assistant tool call failures masked as success

[moona3k]

In OpenAI Assistant, when a tool call fails, it's currently logged as a success in observability platforms instead of a failure. This PR correctly calls onToolError instead of onToolEnd in catch blocks.

[gemini-code-assist]

Summary of Changes

Hello @moona3k, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request resolves an issue where the OpenAI Assistant agent was misreporting tool execution failures as successes in analytics platforms. By updating the error handling logic to use the appropriate onToolError analytic handler, the change ensures that all tool failures are now accurately logged as failed spans. This provides a more truthful and consistent view of tool performance and execution outcomes across the application's analytics.

Highlights

• Analytics Correction: Tool execution failures in the OpenAI Assistant agent were previously logged as successful spans due to an incorrect analytics handler call.
• Accurate Error Reporting: The change switches the analytics call from onToolEnd to onToolError within catch blocks, ensuring that tool failures are now correctly marked as failed spans.
• System Consistency: This update aligns the error reporting behavior of the OpenAI Assistant agent with the analytics standards used by other agents and tools in the system.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request correctly addresses an issue where tool execution errors were being logged as successful events in the analytics system. By switching from onToolEnd to onToolError in the catch blocks, failed tool executions will now be properly marked as failures. I've included a few suggestions to further improve the error logging by ensuring the error details are properly serialized, which will make the analytics data more useful for debugging.

[HenryHengZJ]

thanks!