-
-
Notifications
You must be signed in to change notification settings - Fork 23.5k
Feature/Gemini Nano Banana #5529
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @HenryHengZJ, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly enhances the platform's multimodal capabilities, particularly for Gemini models. It introduces new model definitions and refines the handling of image artifacts throughout the chat flow. The changes ensure that images, whether from user uploads, generated by tools, or embedded in LLM responses, are consistently processed, stored, and presented, leading to a more robust and visually aware conversational experience. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces support for image generation and vision capabilities, particularly for Gemini models, within the agent and LLM nodes. It includes a significant and beneficial refactoring, moving shared artifact and image handling logic from the Agent node into a new utils.ts file. This greatly improves code organization and reusability. The implementation correctly handles passing image artifacts between conversation turns by adding temporary messages, and it properly manages the storage of these artifacts by replacing base64 data with file references. The changes are well-structured and address the new feature requirements effectively. I've included a few suggestions to further improve maintainability and type safety.
* add ability to support gemini nano banana image generation * increment Agent node version
nanobanana.mp4