Skip to content

Comments

Bugfix/create postgresql table if not exists for vectorstore#5573

Merged
HenryHengZJ merged 1 commit intomainfrom
bugfix/PostgresQL-Vector-Store-Create-Table-If-Not-Exists
Dec 12, 2025
Merged

Bugfix/create postgresql table if not exists for vectorstore#5573
HenryHengZJ merged 1 commit intomainfrom
bugfix/PostgresQL-Vector-Store-Create-Table-If-Not-Exists

Conversation

@HenryHengZJ
Copy link
Contributor

No description provided.

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @HenryHengZJ, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly enhances the PostgreSQL vector store integration by introducing robust support for database schemas and ensuring the automatic creation of the vector store table and the essential pgvector extension. These changes address potential issues where the table might not exist, thereby streamlining the setup and usage of PostgreSQL vector stores and improving overall reliability.

Highlights

  • Schema Support: Added functionality to specify and utilize a PostgreSQL schema for vector store tables, allowing for better organization and isolation of data.
  • Automatic Table Creation: Implemented logic to automatically create the PostgreSQL vector store table and the necessary pgvector extension if they do not already exist when documents are added, preventing runtime errors.
  • Refactored Table Path Handling: Centralized the logic for constructing the full table path (including schema) within the VectorStoreDriver to improve consistency and maintainability across the codebase.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a bugfix to ensure that the PostgreSQL table for the vector store is created if it doesn't exist, and adds support for specifying a schema. The changes are well-implemented, introducing helper methods for schema and table path construction, and a new method to handle database object creation (ensureTableInDatabase). My main feedback is a performance consideration regarding where this check is performed. I've left a specific comment on how to improve this.

@HenryHengZJ HenryHengZJ merged commit d17c439 into main Dec 12, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Upserting documents in flowise 3.0.12 doesn't create the table when using PostgreSQL integration

1 participant