Increase salt rounds for new passwords, and update hash with more salt rounds for old passwords#5665
Merged
christopherholland-workday merged 5 commits intomainfrom Jan 28, 2026
Merged
Conversation
Today, the application defaults to 5 salt rounds, increasing to 10 which is suggested by OWASP.
Contributor
There was a problem hiding this comment.
Code Review
This pull request is a great security improvement. It increases the bcrypt salt rounds to the recommended value of 10 and implements a seamless upgrade path for existing users' passwords upon login. The changes are well-structured, introducing utility functions for checking and upgrading hashes. I have a few suggestions to reduce code duplication and improve maintainability, primarily around centralizing the logic for determining salt rounds and using the new getHash utility consistently.
yau-wd
approved these changes
Jan 28, 2026
igor-magun-wd
approved these changes
Jan 28, 2026
vellanki-santhosh
pushed a commit
to vellanki-santhosh/Flowise
that referenced
this pull request
Feb 17, 2026
…t rounds for old passwords (FlowiseAI#5665) * Increase Default Salt Rounds from 5 to 10 Today, the application defaults to 5 salt rounds, increasing to 10 which is suggested by OWASP. * Increase salt rounds * feat(encryption.util.ts): add reusable getPasswordSaltRounds function --------- Co-authored-by: yau-wd <yau.ong@workday.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Today, the application defaults to 5 salt rounds, increasing to 10 which is suggested by OWASP.
Additionally, adding a check to the login method to see if the existing has uses 10 rounds or not using the
bcrypt.getRounds()method, and updating the hash if it is less than 10 rounds.Testing Details
if (hashNeedsUpgrade(user.credential!, minRounds))) confirming that the check worked and determined there were insufficient salt rounds