Smooth linear filter parameter change#1432
Merged
Conversation
fres is clearly given in absolute cents. it is later combined with fres_mod, which is given in relative cents
interpolation for Q still missing, updating the coeffs when Q changes still missing
|
spessasus
approved these changes
Nov 25, 2024
Contributor
spessasus
left a comment
spessasus
left a comment
There was a problem hiding this comment.
LGTM, should release this ASAP as it fixes modEnv filter which I consider a major (commonly used) SF2 feature.
Member
Author
|
Thanks for the feedback, I'm on it. |
DominusExult
added a commit
to DominusExult/fluidsynth-sans-glib
that referenced
this pull request
Dec 27, 2024
* master: (66 commits) Add portamento test files Restore discovery of libsndfile on Ubuntu (FluidSynth#1454) Fix crash on startup when there are no MIDI devices (FluidSynth#1447) Replace VERSIONINFO resource cmake macro (FluidSynth#1449) Fix filter processing order in DSP chain (FluidSynth#1444) Render the nervous filter with additional soundfonts Add Christian's SF2 spec test to regression tests Bump testdata ref Migrate test files from LFS to submodule Delete test files from Git LFS Bump to 2.4.1 Smooth linear filter parameter change (FluidSynth#1432) Reenable AWE32 NRPN 23 and 24 (FluidSynth#1430) indentation issue Disable chorus for Uplift - it's too noisy in the middle part Add Klerg's renderings of Altitude and Uplift updated cmake build system * debug output for libsndfile, quieter output for pulseaudio * enhanced build summary report * revised building win32 binaries without unicode support add cmake output for sndfile issues Fix CI builds (FluidSynth#1435) Add test files for AWE32 NRPN (FluidSynth#1434) ...
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements a smooth change of the IIR filter parameters
fres(=filter cutoff frequency) andQ. It is meant as a proper replacement for the previous linear smoothing of the individual filter coefficients, see #1345.This PR is supposed to fix the clicks and pops heard in those related issues:
Fixes #1415
Fixes #1417
Fixes #1424
PR Depends on:
#1429
#1430
Open TODOs:
8*FLUID_BUFSIZEcan be shortened