Apply *_FOR_BUILD environment variables to gentables#1501
Merged
derselbst merged 3 commits intoFluidSynth:masterfrom Mar 16, 2025
Merged
Apply *_FOR_BUILD environment variables to gentables#1501derselbst merged 3 commits intoFluidSynth:masterfrom
derselbst merged 3 commits intoFluidSynth:masterfrom
Conversation
derselbst
reviewed
Mar 15, 2025
Member
derselbst
left a comment
derselbst
left a comment
There was a problem hiding this comment.
Since you're very persistent about this one, I would be willing to buy this proposal. Yet, I don't like it, because introduces a second way to specify the host compiler, next to already existing FLUID_HOST_COMPILER. This is an inconsistent Mischmasch. Pls. decide for one approach and show some love to the comments, too.
(Superseding FLUID_HOST_COMPILER with this approach is a valid option.)
derselbst
reviewed
Mar 15, 2025
derselbst
reviewed
Mar 15, 2025
|
derselbst
approved these changes
Mar 16, 2025
Member
derselbst
left a comment
derselbst
left a comment
There was a problem hiding this comment.
LTGM. For the record, here's the motivation for this change: #1479 (comment)
derselbst
changed the title
Contributor
Author
|
Thank you, your patience is appreciated. 😽 |
DominusExult
added a commit
to DominusExult/fluidsynth-sans-glib
that referenced
this pull request
Apr 7, 2025
* master: (51 commits) Put fluidsynth.lock in its own directory (FluidSynth#1528) Fix XG Drum bank selection (FluidSynth#1514) Stop SDL3 intercepting signals (FluidSynth#1520) Fix MSVC type truncation warnings (FluidSynth#1515) Fix SDL3.dll not included in prebuilt Windows Binaries (FluidSynth#1518) Fix Altitude test case Update testcases for FluidSynth#1508 Apply *_FOR_BUILD environment variables to gentables (FluidSynth#1501) Add testfiles for FluidSynth#1496 and FluidSynth#1505 Remove unused enum Bump to 2.4.4 Fix ordering and dependencies in fluidsynth.service file (FluidSynth#1500) fluidsynth.1: Some remarks and a patch with editorial changes for this man page (FluidSynth#1499) Add support for SDL3 (FluidSynth#1485) Fix interruptions of real-time playback (FluidSynth#1494) Add two more test cases Log SysEX System ON Messages Return error code on server failure Rephrase error messages for clarity Only run one FluidSynth service at a time ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the last attempt (I promise!) to address this unfortunate topic. This patch has been applied to the fluidsynth_2.4.3+dfsg-3 Debian package since February 25th and has proved doing what it's supposed to do:
https://salsa.debian.org/multimedia-team/fluidsynth/-/jobs/7156765
It has also proved to work well in a cross building environment:
http://crossqa.debian.net/src/fluidsynth