Use __android_log_print in fluid_default_log_function in Android#1621
Merged
derselbst merged 1 commit intoFluidSynth:masterfrom Aug 6, 2025
Merged
Use __android_log_print in fluid_default_log_function in Android#1621derselbst merged 1 commit intoFluidSynth:masterfrom
derselbst merged 1 commit intoFluidSynth:masterfrom
Conversation
derselbst
reviewed
Aug 5, 2025
Member
derselbst
left a comment
derselbst
left a comment
There was a problem hiding this comment.
Generally, looks good to me, thanks. One comment below.
neoharp-dev
force-pushed
the
add-logging-on-android
branch
3 times, most recently
from
f2164c1 to
c06bcd0
Compare
derselbst
reviewed
Aug 5, 2025
neoharp-dev
force-pushed
the
add-logging-on-android
branch
from
c06bcd0 to
919014c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On Android, you won't be able to see the output sent to stdout in the logcat output.
This PR makes default log destination on Android to be the main Android log with
__android_log_print, as a developer on Android platform would usually expect