Implement verbose generator parsing#1634
Merged
derselbst merged 10 commits intorelease/2.4from Aug 30, 2025
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR implements verbose generator parsing for fluidsynth soundfont loading by adding detailed explanations when generators are dropped or invalid. It also promotes out-of-memory error messages from ERR to PANIC level for better visibility of critical failures.
- Enhances the
fluid_gen_name()function to handle invalid generator IDs - Adds comprehensive logging messages explaining why generators are discarded during soundfont parsing
- Promotes out-of-memory log messages from ERR to PANIC level across the codebase
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| src/synth/fluid_gen.c | Updates fluid_gen_name() to return string representation of invalid generator IDs |
| src/sfloader/fluid_sffile.c | Adds detailed logging for dropped generators and promotes OOM messages to PANIC level |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


This PR adds detailed explanations about why fluidsynth drops certain generator. It also promotes some out of memory messages to
PANIClevel.Resolves #829.