Skip to content

Implement verbose generator parsing#1634

Merged
derselbst merged 10 commits intorelease/2.4from
issue-829
Aug 30, 2025
Merged

Implement verbose generator parsing#1634
derselbst merged 10 commits intorelease/2.4from
issue-829

Conversation

@derselbst
Copy link
Member

This PR adds detailed explanations about why fluidsynth drops certain generator. It also promotes some out of memory messages to PANIC level.

Resolves #829.

@derselbst derselbst added this to the 2.5 milestone Aug 22, 2025
@derselbst derselbst modified the milestones: 2.5, 2.4 Aug 22, 2025
@derselbst derselbst requested a review from Copilot August 22, 2025 19:17
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR implements verbose generator parsing for fluidsynth soundfont loading by adding detailed explanations when generators are dropped or invalid. It also promotes out-of-memory error messages from ERR to PANIC level for better visibility of critical failures.

  • Enhances the fluid_gen_name() function to handle invalid generator IDs
  • Adds comprehensive logging messages explaining why generators are discarded during soundfont parsing
  • Promotes out-of-memory log messages from ERR to PANIC level across the codebase

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.

File Description
src/synth/fluid_gen.c Updates fluid_gen_name() to return string representation of invalid generator IDs
src/sfloader/fluid_sffile.c Adds detailed logging for dropped generators and promotes OOM messages to PANIC level

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@derselbst derselbst linked an issue Aug 22, 2025 that may be closed by this pull request
@derselbst derselbst merged commit d192031 into release/2.4 Aug 30, 2025
48 of 68 checks passed
@derselbst derselbst deleted the issue-829 branch August 30, 2025 09:32
@sonarqubecloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
9.2% Duplication on New Code (required ≤ 5%)

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Debug output for discarded generators

2 participants