Conversation
…rashLoopBackOff) The getResourceStatus function was only returning pod.status.phase which doesn't reflect container-level statuses like CrashLoopBackOff, ImagePullBackOff, OOMKilled, etc. This adds a getPodStatus function that mirrors kubectl's own logic by inspecting container statuses, init container statuses, and deletion timestamps. Fixes #273 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
kubectl_getreporting incorrect pod status (e.g. "Running" instead of "CrashLoopBackOff")getPodStatus()function that mirrors kubectl's own status computation logic frompkg/printers/internalversion/printers.gostate.waiting.reason,state.terminated.reason), init container statuses, and pod deletion timestamps to derive the human-friendly statusBackground
Previously,
getResourceStatus()only returnedpod.status.phase, which is the pod lifecycle phase (Running, Pending, Succeeded, Failed, Unknown). This doesn't reflect container-level statuses like CrashLoopBackOff, ImagePullBackOff, OOMKilled, Error, etc. A pod can havephase: Runningwhile its container is in CrashLoopBackOff.This was first identified in PR #130 which renamed
statustophaseto be more semantically accurate, but the underlying problem of not showing container-level statuses remained. Issue #273 reports the same problem in the current kubectl CLI-based implementation.Test plan
bun run buildto confirm clean buildFixes #273
🤖 Generated with Claude Code