Skip to content

Fixed #59#60

Open
3kami3 wants to merge 3 commits intoFmstrat:masterfrom
3kami3:fixed_#59
Open

Fixed #59#60
3kami3 wants to merge 3 commits intoFmstrat:masterfrom
3kami3:fixed_#59

Conversation

@3kami3
Copy link
Copy Markdown

@3kami3 3kami3 commented Apr 3, 2024

Fixed #59.

@Fmstrat
Copy link
Copy Markdown
Owner

Fmstrat commented Apr 3, 2024

Thank you for the PR. Will this cause issues for people already running as root on upgrade with file permissions? If so, we will need to include a check, or allow supplying of a user on the ENV with default to root so it's not a breaking change.

@3kami3
Copy link
Copy Markdown
Author

3kami3 commented Apr 4, 2024

Thank you for the PR. Will this cause issues for people already running as root on upgrade with file permissions? If so, we will need to include a check, or allow supplying of a user on the ENV with default to root so it's not a breaking change.

Errors and warnings are output in the current latest version, but nothing is specified, so the supervisord process is already running with root privileges.
If I add user=root to the configuration file, the errors and warnings do not occur. I see no effect on file permissions.

@Fmstrat
Copy link
Copy Markdown
Owner

Fmstrat commented Apr 5, 2024

Sounds good. Why the addition of the insecure http server? For that to be merged we'd need a good case for it, and it would need to be an option via env along with the credentials.

@3kami3
Copy link
Copy Markdown
Author

3kami3 commented Apr 8, 2024

Sounds good. Why the addition of the insecure http server? For that to be merged we'd need a good case for it, and it would need to be an option via env along with the credentials.

The reason for adding the unix_http_server section is
"CRIT Server 'unix_http_server' running without any HTTP authentication checking".
The solution is based on the following supervisor issue
Supervisor/supervisor#694
Supervisor/supervisor#717 (comment)

kapdap added a commit to kapdap/samba-domain that referenced this pull request Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug: Supervisord Error and Warning

2 participants