Skip to content

fix: improve detection of hidden numbers in call logs #595

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
naveensingh merged 2 commits into from
Oct 1, 2025
Merged

fix: improve detection of hidden numbers in call logs #595

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e7d1a7d
fix: improve detection of hidden numbers in call logs
naveensingh Sep 29, 2025
fd00e24
docs: update changelog
naveensingh Oct 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
## [Unreleased]
### Fixed
- Fixed wrong contact photo in call history for some contacts ([#585])
- Fixed hidden/private number detection in call history ([#594])
- Fixed search not matching full phone numbers

## [1.7.1] - 2025-09-12
Expand Down Expand Up @@ -200,6 +201,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
[#543]: https://github.com/FossifyOrg/Phone/issues/543
[#565]: https://github.com/FossifyOrg/Phone/issues/565
[#585]: https://github.com/FossifyOrg/Phone/issues/585
[#594]: https://github.com/FossifyOrg/Phone/issues/594

[Unreleased]: https://github.com/FossifyOrg/Phone/compare/1.7.1...HEAD
[1.7.1]: https://github.com/FossifyOrg/Phone/compare/1.7.0...1.7.1
Expand Down
11 changes: 9 additions & 2 deletions app/src/main/kotlin/org/fossify/phone/helpers/RecentsHelper.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,8 @@ import android.annotation.SuppressLint
import android.content.ContentValues
import android.content.Context
import android.provider.CallLog.Calls
import android.provider.CallLog.Calls.PRESENTATION_UNAVAILABLE
import android.provider.CallLog.Calls.PRESENTATION_UNKNOWN
import android.telephony.PhoneNumberUtils
import org.fossify.commons.extensions.*
import org.fossify.commons.helpers.*
Expand Down Expand Up @@ -141,7 +143,8 @@ class RecentsHelper(private val context: Context) {
Calls.DATE,
Calls.DURATION,
Calls.TYPE,
Calls.PHONE_ACCOUNT_ID
Calls.PHONE_ACCOUNT_ID,
Calls.NUMBER_PRESENTATION
)

val accountIdToSimAccountMap = HashMap<String, SIMAccount>()
Expand Down Expand Up @@ -179,7 +182,11 @@ class RecentsHelper(private val context: Context) {
val id = cursor.getIntValue(Calls._ID)
var isUnknownNumber = false
val number = cursor.getStringValueOrNull(Calls.NUMBER)
if (number == null || number == "-1") {
val presentation = cursor.getIntValueOrNull(Calls.NUMBER_PRESENTATION) ?: Calls.PRESENTATION_ALLOWED
val presentationBlocked = presentation == PRESENTATION_UNKNOWN
|| presentation == PRESENTATION_UNAVAILABLE
|| presentation == Calls.PRESENTATION_RESTRICTED
Comment thread
naveensingh marked this conversation as resolved.
if (presentationBlocked || number.isNullOrBlank() || number == "-1") {
isUnknownNumber = true
}

Expand Down
Loading