Instrument Input#24
Conversation
|
I just finished a blog post about the new addon: |
|
@stv0g Please contact me at my email to begin the review process. |
|
Hi @stv0g -- it looks to me like this is basically ready to go in, with the exception that the Python package you are using isn't available for Python <= 3.10, so should be removed from those files. This will prevent the Addon from working with older versions of FreeCAD, but that likely won't affect many people. |
b614e6b to
85fd0d4
Compare
85fd0d4 to
8fdf354
Compare
|
@PhoneDroid I have addressed the review comments which you've provided via E-Mail. @chennes I lowered the minimal required Python version to 3.10. So we should be fine here. |
|
🤖 Constraints Bot: regenerated the constraints files and added a commit with the changes |
|
Thanks, @stv0g -- I don't know what issues @PhoneDroid's already flagged, but could you please add a bullet point near the top of your README explaining that this Addon continuously scans for nearby BLE devices when running? Most people will understand that's how it works, but in the interest of transparency it's best to be explicit about it. |
|
@chennes Thanks for the input. I have added such a note in v0.3.1. @PhoneDroid has raised these points: Manifest
Code
|
|
Thanks, @stv0g -- this one, "Use PySide6 instead of PySide for imports", isn't really true, but won't matter until Qt releases Qt7, so you have a bit of time to back it out :). I'll go ahead and add this addon in the meantime, it should be available via the addon manager tomorrow. |
I got bored of manually measuring and entering dimensions during 3D modelling.
So, I got a Bluetooth-connected caliper and hacked together a new #FreeCAD addon to use it as an input device.
https://codeberg.org/stv0g/InstrumentInput
This addon is relatively fresh. Currently only digital Sylvac calipers are supported.
But more measurement devices could be added later.
For clarification: Is this repo already used by the current version of the AddonManager in FC v1.1?