AddonManager: Add DesignSPHysics workbench icon#2623
AddonManager: Add DesignSPHysics workbench icon#2623yorikvanhavre merged 1 commit intoFreeCAD:masterfrom
Conversation
|
Just one thing, the .svg is 648K which is unnecessary. It's already 'minified' but we should compress it further, any ideas ? |
|
What does it mean it is "minified"? The SVG icon is way too big. It should be 64x64 px max. This thing has a native size of 1024x1024 px. Also, one of the elements, the blue-redish waves, is in fact a bitmap embedded in the file. Without this bitmap, the file size reduces to 5 KB. I don't think this should be included in the Addon Manager like this. The waves should be re-drawn in Inkscape as vector elements (paths). They should also be simpler; right now they have way too many details (many small colored circles), that these details won't be noticeable at the normal resolutions at which the icons would be displayed, from 64x64 px to 16x16 px. Said in another way. The image is fine as a splash screen, but not as an icon. |
|
I'll post it to the UI/UX forum and ask if someone can scale this down then. |
|
It's not just about scaling. After all, it is an SVG already, it can be scaled indefinitely. But the bitmap image should be re-drawn to be a vector graphic or "path" in Inkscape terms. |
I thought it was something that had to do with compression, but it's actually just taking whitespace out of .svg markup, like you would minify a .js file, if you will. So not very helpful actually. |
|
Forum thread: https://forum.freecadweb.org/viewtopic.php?f=34&t=40136 |
a922e1b to
a71a10d
Compare
Closes DualSPHysics/DesignSPHysics#14 Note: Swapped out logo from upstream with one that we've modified downstream. Forum thread: https://forum.freecadweb.org/viewtopic.php?f=34&t=40136
a71a10d to
f5d48da
Compare
|
Thanks @vocx for modifying the SVG to an appropriate size. Note: @zlotny please check out https://forum.freecadweb.org/viewtopic.php?f=34&t=40136 just so you know what we've done. If you want to change this feel free to submit a PR. This PR is ready for merge |
Closes DualSPHysics/DesignSPHysics#14
ref: FreeCAD/FreeCAD-addons#37