cli: No updates available for schema shouldn't be an error

[bukowa]

I am just setting up Makefile for building mod and I encounter this issue when up-to-date schema causes error.
I believe this is a mistake, and it should be just a warning.

rpfm/rpfm_lib/src/integrations/git.rs

Lines 201 to 215 in e1fa95b

	// If we're up to date, nothing more is needed.
	if analysis.0.is_up_to_date() {
	// Reset the repo to his original state after the check
	if current_branch_name != master_refname {
	self.checkout_branch(&repo, &current_branch_name)?;
	}
	if stash_id.is_ok() {
	let _ = repo.stash_pop(0, None);
	}
	Err(RLibError::GitErrorNoUpdatesAvailable(self.url.to_owned()))
	}
	// If we can do a fast-forward, we do it. This is the preferred option.

$ make init
cd ./contrib/rpfm && \
        rpfm_cli --game rome_2 schemas update --schema-path ./
17:28:13 [INFO] Logger initialized.
17:28:13 [INFO] Sentry Logging support enabled. Starting...
17:28:14 [ERROR] No updates available for the following git repository: https://github.com/Frodo45127/rpfm-schemas.
make: *** [init] Error 1

[Frodo45127]

I have vague memories of this. The theory was that, when that code was written, that function could not be called unless it had first passed through the check_updates function and that one had returned that there were updates. Meaning if there are updates but a second later there are not, it's an error.

That's not the case anymore, so yes, it should return an Ok, but with either a message or an enum saying that it was ok because there were no updates. Other it may cause a silent failure when there are updates, but something else fails giving the impression that there are no updates.

[bukowa]

Ok seems like a good first issue to fire that rust and start fiddling with rpfm
I think it would be very good to label this as "Good First Issue".

[Frodo45127]

Ok seems like a good first issue to fire that rust and start fiddling with rpfm I think it would be very good to label this as "Good First Issue".

Done. I actually didn't had that label in the label list...