Skip to content

feat: add SESSION_COOKIE_AGE environment variable#1201

Open
pogman-code wants to merge 2 commits intoFuzzyGrim:devfrom
pogman-code:session-cookie-age
Open

feat: add SESSION_COOKIE_AGE environment variable#1201
pogman-code wants to merge 2 commits intoFuzzyGrim:devfrom
pogman-code:session-cookie-age

Conversation

@pogman-code
Copy link
Copy Markdown
Contributor

Add SESSION_COOKIE_AGE environment variable to allow adjustment of session cookie expiration date (see: https://docs.djangoproject.com/en/dev/ref/settings/#session-cookie-age)

Closes/Resolves #1185

(Thanks @FuzzyGrim for pointing me to the solution 😉 )

@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello @pogman-code, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the application's configurability by introducing a new environment variable, SESSION_COOKIE_AGE. This allows administrators to easily adjust the lifespan of session cookies without modifying code, providing greater control over user session management and security.

Highlights

  • New Environment Variable: Introduced SESSION_COOKIE_AGE environment variable to control the expiration duration of session cookies.
Changelog
  • src/config/settings.py
    • Added SESSION_COOKIE_AGE setting, configurable via environment variable.
Activity
  • The author received assistance from @FuzzyGrim in identifying the solution for this feature.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a new environment variable SESSION_COOKIE_AGE to configure the session cookie's expiration time. The change is straightforward and correctly implemented. I've added one suggestion to improve code readability by replacing the magic number for the default cookie age with a calculation, which is consistent with other parts of the settings file.

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant