feat: add SESSION_COOKIE_AGE environment variable#1201
feat: add SESSION_COOKIE_AGE environment variable#1201pogman-code wants to merge 2 commits intoFuzzyGrim:devfrom
Conversation
Summary of ChangesHello @pogman-code, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances the application's configurability by introducing a new environment variable, Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request introduces a new environment variable SESSION_COOKIE_AGE to configure the session cookie's expiration time. The change is straightforward and correctly implemented. I've added one suggestion to improve code readability by replacing the magic number for the default cookie age with a calculation, which is consistent with other parts of the settings file.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Add
SESSION_COOKIE_AGEenvironment variable to allow adjustment of session cookie expiration date (see: https://docs.djangoproject.com/en/dev/ref/settings/#session-cookie-age)Closes/Resolves #1185
(Thanks @FuzzyGrim for pointing me to the solution 😉 )