Skip to content

Minor date format updates#1205

Open
andrebk wants to merge 2 commits intoFuzzyGrim:devfrom
andrebk:date-format
Open

Minor date format updates#1205
andrebk wants to merge 2 commits intoFuzzyGrim:devfrom
andrebk:date-format

Conversation

@andrebk
Copy link
Copy Markdown
Contributor

@andrebk andrebk commented Feb 15, 2026

Two small changes:

  • Use user date format preference for episode air dates
  • Add a long date format for "EU" day/month order

@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello @andrebk, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances date display flexibility by integrating user-specific date format preferences for episode air dates and introducing a new long date format tailored for European day/month ordering. These changes improve localization and user experience by presenting dates in a more familiar and readable manner.

Highlights

  • User Date Format Preference: Episode air dates on the media details page now respect the user's preferred date format.
  • New Date Format Added: A new long date format (18 Jan, 2026) has been introduced to support European day/month order.
Changelog
  • src/templates/app/media_details.html
    • Updated the display of episode air dates to use the iso_date_format filter, applying the request.user's preferred date format.
  • src/users/models.py
    • Added a new LONG_EU choice to the DateFormatChoices enum, providing a 'j M, Y' format for '18 Jan, 2026'.
Activity
  • No human activity has been recorded on this pull request yet.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces two small but useful date formatting updates. A new long date format for European users has been added, and episode air dates now respect the user's preferred date format. The changes are well-aligned with the description. I've left one comment regarding code consistency in the template file to improve maintainability.

<h2 class="text-xl font-semibold mb-1 line-clamp-1">{{ episode.title }}</h2>
<p class="text-sm text-gray-400">
Episode {{ episode.episode_number }} • {{ episode.air_date|default_if_none:"Unknown air date" }}
Episode {{ episode.episode_number }} • {{ episode.air_date|iso_date_format:request.user|default_if_none:"Unknown air date" }}
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

For consistency with other parts of this file (e.g., line 446), it's better to apply the default_if_none filter before iso_date_format. This ensures a consistent pattern for handling potentially missing dates throughout the template.

                            Episode {{ episode.episode_number }} • {{ episode.air_date|default_if_none:"Unknown air date"|iso_date_format:request.user }}

@codecov
Copy link
Copy Markdown

codecov bot commented Feb 15, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 81.44%. Comparing base (c2d4c55) to head (2f6642a).
⚠️ Report is 2 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #1205      +/-   ##
==========================================
+ Coverage   81.38%   81.44%   +0.05%     
==========================================
  Files          70       70              
  Lines        7258     7259       +1     
==========================================
+ Hits         5907     5912       +5     
+ Misses       1351     1347       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant