Enhancing the new cast list by McBaumwolle · Pull Request #1207 · FuzzyGrim/Yamtrack

McBaumwolle · 2026-02-16T11:19:48Z

This PR (draft as it is still buggy but wanted to put it there anyway for review, etc.) changes the handy new cast view (from @connorjburton) to be horizontally scrollable, similar to what trakt does at the moment.

Details

I tried a separate button (like discussed here) which did not work (for me) and was kinda inconvenient when there was a giant cast list. I increased the cast fetch number from 10 to 30, and if there are more it adds a button/card in the end linking to TMDB. This is a bit buggy right now, hence the draft.

Issues

Calculation bug
The side bar gets squeezed a bit - Somewhere I broke the sidebar, or the changed cast section pushes it away.

gemini-code-assist · 2026-02-16T11:20:03Z

Summary of Changes

Hello @McBaumwolle, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the user experience on media detail pages by revamping the cast display. It transitions the cast section to a more dynamic, horizontally scrollable layout, allowing users to easily browse a larger number of cast members. Additionally, it provides a convenient way to access the complete cast list on TMDB when many cast members are present, streamlining the discovery of related information.

Highlights

Horizontally Scrollable Cast View: The cast section on media detail pages has been updated to be horizontally scrollable, similar to the Trakt platform, improving navigation for large cast lists.
Increased Cast Fetch Limit: The number of cast members fetched from TMDB has been increased from 10 to 30, providing more comprehensive cast information directly on the page.
Dynamic 'View All' Button: A 'View All' button/card is now displayed at the end of the cast list if there are more than 20 cast members, linking directly to the full cast list on TMDB.
Draft Status: This pull request is currently in draft status, indicating that there are known bugs or ongoing work, particularly with the 'View All' functionality.

Changelog

src/app/providers/tmdb.py
- Increased the number of cast members retrieved from TMDB for a movie from 10 to 30.
src/templates/app/components/cast_card.html
- Adjusted the card's dimensions and flex properties to support horizontal scrolling.
- Updated image and link container styling for better responsiveness and hover effects.
- Changed the external link button from an anchor tag to a div with a title attribute.
- Refined padding and margin for cast name and character details.
src/templates/app/media_details.html
- Converted the cast display from a grid layout to a horizontally scrollable flex container.
- Limited the number of cast members displayed to the first 30.
- Added a 'View All' card that links to the TMDB page if more than 20 cast members are available.
- Removed an outdated comment related to media card highlighting.

Activity

The pull request was opened as a draft by McBaumwolle, indicating that work is still in progress and there are known issues, particularly with the 'View All' button functionality.
The author has explicitly requested review despite the draft status, suggesting a desire for early feedback on the implemented changes.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	`/gemini review`	Performs a code review for the current pull request in its current state.
Pull Request Summary	`/gemini summary`	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	`/gemini help`	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist

Code Review

This pull request refactors the cast view to be a horizontally scrollable list, which is a nice UI improvement. I've left a few comments to address a bug you mentioned in the description regarding the 'View All' button, and some suggestions to improve maintainability by replacing inline CSS styles with Tailwind utility classes. Overall, good work on this feature!

src/templates/app/media_details.html

gemini-code-assist · 2026-02-16T11:21:57Z

src/templates/app/components/cast_card.html

+<div class="shrink-0 bg-[#2a2f35] rounded-lg overflow-hidden shadow-lg group flex flex-col"
+     style="width: 176px;
+            min-width: 176px;
+            height: 264px"
+     role="listitem">


Using inline styles for width and height can make maintenance harder. It's better to use Tailwind CSS utility classes for consistency. You can replace these inline styles with w-44 min-w-44 h-[264px].

<div class="shrink-0 bg-[#2a2f35] rounded-lg overflow-hidden shadow-lg group flex flex-col w-44 min-w-44 h-[264px]" role="listitem">

gemini-code-assist · 2026-02-16T11:21:57Z

src/templates/app/components/cast_card.html

+  <a href="https://www.themoviedb.org/person/{{ cast.id }}"
+     target="_blank"
+     class="relative block w-full"
+     style="height: 78%">


Using a percentage-based height can be fragile and lead to unexpected layout issues if the parent's height changes. A more robust approach would be to give the text container below a fixed height and let this image container take the remaining space using flex-1.

For example, you could give the div on line 25 a class like h-16 and change this a tag to have flex-1 and remove the inline style.

gemini-code-assist · 2026-02-16T11:21:57Z

src/templates/app/media_details.html

+                 class="shrink-0 bg-[#2a2f35] rounded-lg shadow-lg flex flex-col items-center justify-center hover:bg-[#343a40] transition-colors duration-200"
+                 style="width: 176px;
+                        min-width: 176px;
+                        height: 264px">


Similar to the cast_card.html component, it's better to use Tailwind CSS utility classes instead of inline styles for consistency and maintainability.

class="shrink-0 bg-[#2a2f35] rounded-lg shadow-lg flex flex-col items-center justify-center hover:bg-[#343a40] transition-colors duration-200 w-44 min-w-44 h-[264px]">

…cast-clean

…ed some of my comments)

McBaumwolle · 2026-02-18T11:38:41Z

I tried all the suggestions from the bot about Tailwind instead of inline styles, but the layout kept collapsing (the cast cards then only had the width of the person's name). I'd suggest keeping the inline styles, but @FuzzyGrim has to decide on this as it's not a perfect solution. As far as I see it, it does not break parent columns (right now!?) and the rest of the PR works as expected on my end. Juts let me know if that works for you, otherwise I just have to learn some Tailwind haha.

FuzzyGrim · 2026-04-01T13:33:11Z

Thanks! It looks great!

I can try fixing the inline styling as a follow up.

mcbaumwolle added 2 commits February 16, 2026 12:17

feat: horizontal scrollable cast view with TMDB links

1272967

Fixing forgotten value

4c3be87

gemini-code-assist bot reviewed Feb 16, 2026

View reviewed changes

McBaumwolle changed the title ~~Dev cast clean~~ Enhancing the new cast list Feb 16, 2026

mcbaumwolle added 5 commits February 16, 2026 13:52

Fixes 30 cast limit and display

a9a5870

feat: make only cast icon clickable (no fixes tho)

cdb13a9

feat: restore full card link and fix placeholder stretching

e039fac

Merge branch 'dev' of https://github.com/FuzzyGrim/Yamtrack into dev-…

929ecaa

…cast-clean

Fixing bug on my part which squished the sidebar on movies (and remov…

5dae3d4

…ed some of my comments)

McBaumwolle marked this pull request as ready for review February 18, 2026 11:38

FuzzyGrim merged commit 49a94ad into FuzzyGrim:dev Apr 1, 2026
1 check passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Enhancing the new cast list#1207

Enhancing the new cast list#1207
FuzzyGrim merged 7 commits intoFuzzyGrim:devfrom
McBaumwolle:dev-cast-clean

McBaumwolle commented Feb 16, 2026 •

edited

Loading

Uh oh!

gemini-code-assist bot commented Feb 16, 2026

Uh oh!

gemini-code-assist bot left a comment

Uh oh!

Uh oh!

gemini-code-assist bot Feb 16, 2026

Uh oh!

gemini-code-assist bot Feb 16, 2026

Uh oh!

gemini-code-assist bot Feb 16, 2026

Uh oh!

McBaumwolle commented Feb 18, 2026

Uh oh!

Uh oh!

FuzzyGrim commented Apr 1, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

McBaumwolle commented Feb 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Issues

Uh oh!

gemini-code-assist bot commented Feb 16, 2026

Summary of Changes

Highlights

Footnotes

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

gemini-code-assist bot Feb 16, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist bot Feb 16, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist bot Feb 16, 2026

Choose a reason for hiding this comment

Uh oh!

McBaumwolle commented Feb 18, 2026

Uh oh!

Uh oh!

FuzzyGrim commented Apr 1, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

McBaumwolle commented Feb 16, 2026 •

edited

Loading