Skip to content

Enhance external ID extraction with series fallback#1210

Open
artifaxx wants to merge 2 commits intoFuzzyGrim:devfrom
artifaxx:enhance-jellyfin-external-id-extraction
Open

Enhance external ID extraction with series fallback#1210
artifaxx wants to merge 2 commits intoFuzzyGrim:devfrom
artifaxx:enhance-jellyfin-external-id-extraction

Conversation

@artifaxx
Copy link
Copy Markdown

Update external ID extraction to fallback to the Series ProviderIds when it's not present on the episode.

Fixes #1209

@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello @artifaxx, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the robustness of external ID retrieval for Jellyfin webhook events. It introduces a new logic to ensure that if specific external identifiers (like TMDB, IMDb, or TVDB IDs) are missing from an individual media item, the system will attempt to find and utilize these IDs from the parent series, thereby improving data completeness for downstream integrations.

Highlights

  • External ID Extraction: Implemented a fallback mechanism for external ID extraction within Jellyfin webhooks. If Tmdb, Imdb, or Tvdb IDs are not found at the episode (item) level, the system now attempts to retrieve them from the associated series' provider IDs.
Changelog
  • src/integrations/webhooks/jellyfin.py
    • Modified the _extract_external_ids method to include fallback logic for retrieving Tmdb, Imdb, and Tvdb IDs from the series' ProviderIds if they are not present on the item.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@artifaxx artifaxx marked this pull request as ready for review February 16, 2026 16:23
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request enhances the external ID extraction for Jellyfin webhooks by adding a fallback to series-level provider IDs when they are not available at the episode level. The implementation is functionally correct, but it contains repetitive code. I've suggested a refactoring to make the code more concise and maintainable by removing the duplication.

Refactored the _extract_external_ids method to simplify the retrieval of provider IDs by combining item and series checks into a single step.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] TMDB ID Not Extracted

1 participant