add import option for Netflix watch history#1213
add import option for Netflix watch history#12134ndriH wants to merge 4 commits intoFuzzyGrim:devfrom
Conversation
Summary of ChangesHello @4ndriH, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces a significant new integration, allowing users to import their Netflix watch history. By processing CSV files exported from Netflix, the system can now automatically identify and log watched movies and TV series, including specific seasons and episodes, by matching them against TMDb. This enhances the platform's ability to provide a comprehensive tracking solution for user media consumption. Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request introduces a new importer for Netflix watch history from a CSV file. While a great addition, it has potential Denial of Service (DoS) vulnerabilities. Specifically, handling large CSV files by reading the entire file into memory and performing unbounded external API calls and database operations per row can lead to resource exhaustion. Recommendations include implementing streaming file processing and limiting the number of entries processed per task. Additionally, consider improving error handling for resilience, fixing error message formatting, and refactoring for better code clarity and efficiency.
This adds an import option for the Netflix watch history CSV.
The CSV only provides names of the media watched, which has to be matched against TMDb. The matching process currently looks for exact matches which could be improved by utilizing something like min edit distance in the future. I am pointing this out because Netflix does sometimes have small discrepancies when it comes to episode names.
For example the episodes of the tv show Blacklist can additionally contain a number on Netflix, indicating where the blacklister is on Reddingtons list.