Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces a new feature enabling users to import their media tracking data from Watcharr JSON exports. It efficiently reuses the existing Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request introduces a new importer for Watcharr JSON exports, which is a great addition. The implementation is well-structured, reusing the existing YamtrackImporter by refactoring it to be more extensible. The changes are consistent with the project's patterns for importers, including adding a Celery task, URL, view, and UI components. The new tests cover the basic import counts. My review includes a few suggestions for improvement, such as pinning the new dependency, enhancing error messages, making the tests more comprehensive, and some minor code simplifications and fixes.
|
Just wanted to ask the format of the Watcharr dates, because I think that importing the whole |
|
Yes, good point. It should definitely be possible with standard library. My python game is just a bit rusty and I was going safe rather than sorry :) From what I can see, the format of watcharr is also ISO 8601 but with the Z notation instead of "+00:00" and an undefined number of digits for the fractional seconds (e.g. |
This adds an option to import the exported JSON from https://github.com/sbondCo/Watcharr
It only imports the "final" state of each entry. So even though the activity for each entry can be found in the Watcharr JSON, I opted to ignore it for now.
The implementation reuses the basic YamtrackImporter and just reformats the data from JSON into CSV.
I mainly wrote this for myself but extended it as a PR to hopefully be helpful for others too.
Thank you for this great project btw! :)