fix(sdk): Apply SDK fix for coins bug and KDF release update #2637

CharlVS · 2025-05-16T08:57:01Z

Changes:

Roll SDK version which includes:

Fix for coins bug (SDK#55)
KDF release build
Fix for root cause of dex form crash
Windows DLL issue

KW repo changes:

Improvements/fixes to CI SDK roll script

Potentially solves (@smk762 please confirm):

Relevant: #2526 (comment)

- Fix SDK roll CI script issues - Roll SDK version

coderabbitai · 2025-05-16T08:57:08Z

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Explain this complex logic.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai explain this code block.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and explain its main purpose.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

github-actions · 2025-05-16T11:29:05Z

Visit the preview URL for this PR (updated for commit 07ef77d):

https://walletrc--pull-2637-merge-15d2mgca.web.app

_{(expires Thu, 29 May 2025 10:54:52 GMT)}

_{🔥 via Firebase Hosting GitHub Action 🌎}

_{Sign: f66a4ff03faa546f12f0ae5a841bd9eff2714dcc}

smk762 · 2025-05-16T13:06:30Z

In #2624 (comment) it is mentioned that the failed activation log spam was resolved by removing NFT_* coins from the auto activate list.

Unfortunately in testing, I did encounter a similar message as when previously encountering this issue.

GeneralErrorResponse: {"mmrpc":"2.0","error":null,"error_path":null,"error_type":null,"error_data":null,"error_trace":null,"object":{"mmrpc":"2.0","error":"AVAX","error_path":"platform_coin_with_tokens.lp_coins","error_trace":"platform_coin_with_tokens:489] lp_coins:4055]","error_type":"PlatformIsAlreadyActivated","error_data":"AVAX","id":null}}, details: {currentStep: error, stepCount: 2, additionalInfo: {}, errorCode: ERC20_ACTIVATION_ERROR, errorDetails: GeneralErrorResponse: {"mmrpc":"2.0","error":null,"error_path":null,"error_type":null,"error_data":null,"error_trace":null,"object":{"mmrpc":"2.0","error":"AVAX","error_path":"platform_coin_with_tokens.lp_coins","error_trace":"platform_coin_with_tokens:489] lp_coins:4055]","error_type":"PlatformIsAlreadyActivated","error_data":"AVAX","id":null}}, stackTrace: ../dart-sdk/lib/_internal/js_dev_runtime/private/ddc_runtime/errors.dart 307:3   throw_
../komodo_defi_rpc_methods/lib/src/models/base_request.dart 15:7                 <fn>
../dart-sdk/lib/_internal/js_dev_runtime/patch/async_patch.dart 622:19           <fn>
../dart-sdk/lib/_internal/js_dev_runtime/patch/async_patch.dart 647:23           <fn>
../dart-sdk/lib/_internal/js_dev_runtime/patch/async_patch.dart 593:31           <fn>
../dart-sdk/lib/async/zone.dart 1538:47                                          _rootRunUnary
../dart-sdk/lib/async/zone.dart 1429:19                                          runUnary
../dart-sdk/lib/async/future_impl.dart 208:18                                    handleValue
../dart-sdk/lib/async/future_impl.dart 932:44                                    handleValueCallback
../dart-sdk/lib/async/future_impl.dart 961:13                                    _propagateToListeners
../dart-sdk/lib/async/future_impl.dart 712:5                                     [_completeWithValue]
../dart-sdk/lib/_internal/js_dev_runtime/patch/async_patch.dart 503:7            complete
../dart-sdk/lib/_internal/js_dev_runtime/patch/async_patch.dart 570:12           _asyncReturn
../packages/komodo_defi_framework/komodo_defi_framework.dart 166:3               <fn>
../dart-sdk/lib/_internal/js_dev_runtime/patch/async_patch.dart 622:19           <fn>
../dart-sdk/lib/_internal/js_dev_runtime/patch/async_patch.dart 647:23           <fn>
../dart-sdk/lib/_internal/js_dev_runtime/patch/async_patch.dart 593:31           <fn>
../dart-sdk/lib/async/zone.dart 1538:47                                          _rootRunUnary
../dart-sdk/lib/async/zone.dart 1429:19                                          runUnary
../dart-sdk/lib/async/future_impl.dart 208:18                                    handleValue
../dart-sdk/lib/async/future_impl.dart 932:44                                    handleValueCallback
../dart-sdk/lib/async/future_impl.dart 961:13                                    _propagateToListeners
../dart-sdk/lib/async/future_impl.dart 712:5                                     [_completeWithValue]
../dart-sdk/lib/_internal/js_dev_runtime/patch/async_patch.dart 503:7            complete
../dart-sdk/lib/_internal/js_dev_runtime/patch/async_patch.dart 570:12           _asyncReturn
../packages/komodo_defi_framework/src/operations/kdf_operations_wasm.dart 240:3  <fn>
../dart-sdk/lib/_internal/js_dev_runtime/patch/async_patch.dart 622:19           <fn>
../dart-sdk/lib/_internal/js_dev_runtime/patch/async_patch.dart 647:23           <fn>
../dart-sdk/lib/_internal/js_dev_runtime/patch/async_patch.dart 593:31           <fn>
../dart-sdk/lib/async/zone.dart 1538:47                                          _rootRunUnary
../dart-sdk/lib/async/zone.dart 1429:19                                          runUnary
../dart-sdk/lib/async/future_impl.dart 208:18                                    handleValue
../dart-sdk/lib/async/future_impl.dart 932:44                                    handleValueCallback
../dart-sdk/lib/async/future_impl.dart 961:13                                    _propagateToListeners
../dart-sdk/lib/async/future_impl.dart 712:5                                     [_completeWithValue]
../dart-sdk/lib/_internal/js_dev_runtime/patch/async_patch.dart 503:7            complete
../dart-sdk/lib/_internal/js_dev_runtime/patch/async_patch.dart 570:12           _asyncReturn
../packages/komodo_defi_framework/src/operations/kdf_operations_wasm.dart 287:3  <fn>
../dart-sdk/lib/_internal/js_dev_runtime/patch/async_patch.dart 622:19           <fn>
../dart-sdk/lib/_internal/js_dev_runtime/patch/async_patch.dart 647:23           <fn>
../dart-sdk/lib/_internal/js_dev_runtime/patch/async_patch.dart 593:31           <fn>
../dart-sdk/lib/async/zone.dart 1538:47                                          _rootRunUnary
../dart-sdk/lib/async/zone.dart 1429:19                                          runUnary
../dart-sdk/lib/async/future_impl.dart 208:18                                    handleValue
../dart-sdk/lib/async/future_impl.dart 932:44                                    handleValueCallback
../dart-sdk/lib/async/future_impl.dart 961:13                                    _propagateToListeners
../dart-sdk/lib/async/future_impl.dart 712:5                                     [_completeWithValue]
../dart-sdk/lib/async/future_impl.dart 792:7                                     <fn>
../dart-sdk/lib/async/zone.dart 1525:13                                          _rootRun
../dart-sdk/lib/async/zone.dart 1422:19                                          run
../dart-sdk/lib/async/zone.dart 1321:7                                           runGuarded
../dart-sdk/lib/async/zone.dart 1362:23                                          callback
../dart-sdk/lib/async/schedule_microtask.dart 40:11                              _microtaskLoop
../dart-sdk/lib/async/schedule_microtask.dart 49:5                               _startMicrotaskLoop
../dart-sdk/lib/_internal/js_dev_runtime/patch/async_patch.dart 186:7            <fn>

This was followed by

trace: ../dart-sdk/lib/_internal/js_dev_runtime/private/ddc_runtime/errors.dart 307:3              throw_
../packages/komodo_defi_sdk/src/transaction_history/transaction_history_manager.dart 385:7  <fn>
../dart-sdk/lib/_internal/js_dev_runtime/patch/async_patch.dart 622:19                      <fn>
../dart-sdk/lib/_internal/js_dev_runtime/patch/async_patch.dart 647:23                      <fn>
../dart-sdk/lib/_internal/js_dev_runtime/patch/async_patch.dart 593:31                      <fn>
../dart-sdk/lib/async/zone.dart 1538:47                                                     _rootRunUnary
../dart-sdk/lib/async/zone.dart 1429:19                                                     runUnary
../dart-sdk/lib/async/future_impl.dart 208:18                                               handleValue
../dart-sdk/lib/async/future_impl.dart 932:44                                               handleValueCallback
../dart-sdk/lib/async/future_impl.dart 961:13                                               _propagateToListeners
../dart-sdk/lib/async/future_impl.dart 703:7                                                [_complete]
../dart-sdk/lib/async/stream.dart 1687:17                                                   <fn>
../dart-sdk/lib/async/zone.dart 1517:47                                                     _rootRun
../dart-sdk/lib/async/zone.dart 1422:19                                                     run
../dart-sdk/lib/async/zone.dart 1321:7                                                      runGuarded
../dart-sdk/lib/async/stream_impl.dart 434:7                                                sendDone
../dart-sdk/lib/async/stream_impl.dart 444:7                                                [_sendDone]
../dart-sdk/lib/async/stream_impl.dart 592:13                                               perform
../dart-sdk/lib/async/stream_impl.dart 678:10                                               handleNext
../dart-sdk/lib/async/stream_impl.dart 649:7                                                <fn>
../dart-sdk/lib/async/zone.dart 1517:47                                                     _rootRun
../dart-sdk/lib/async/zone.dart 1422:19                                                     run
../dart-sdk/lib/async/zone.dart 1321:7                                                      runGuarded
../dart-sdk/lib/async/zone.dart 1362:23                                                     <fn>
../dart-sdk/lib/async/zone.dart 1525:13                                                     _rootRun
../dart-sdk/lib/async/zone.dart 1422:19                                                     run
../dart-sdk/lib/async/zone.dart 1321:7                                                      runGuarded
../dart-sdk/lib/async/zone.dart 1362:23                                                     callback
../dart-sdk/lib/async/schedule_microtask.dart 40:11                                         _microtaskLoop
../dart-sdk/lib/async/schedule_microtask.dart 49:5                                          _startMicrotaskLoop
../dart-sdk/lib/_internal/js_dev_runtime/patch/async_patch.dart 186:7                       <fn>

AVAX did activate in the end and balance was visible, but history was not, and to get there I had to switch pages to turn the red into blue and green.

This occurs on both an imported and a fresh wallet (so not due to prior activation list). Testing performed on web via local build of 186177908b4529f5b8d99c9abf4dbebed836f1fe

Confirmed KDF version matches 2.4.0-beta release commit hash ✔️
Confirmed EVM coins can be activated (eventually, with some issues along the way) * 🟠
Confirmed Tendermint coins can be activated * 🟠

_This build uses master branch of coins repo. This needs to be retested with test: KDF dev branch with coins chain-id-struct branch #2628 & test: KDF main with coins chain-id-struct branch #2629 ⚠️

Confirmed Tendermint coins are still failing to withdraw 👎

`NFT_` prefixed coins do not have icons and should not be shown to users, so filter them out from the icon pre-caching

smk762 · 2025-05-21T10:43:25Z

Testing from last commit:

No NFT_ activation error loops seen, though saw a couple similar for utxo/evm coins ✔️
NFT coins not seen in activation list options. ✅
Existing NFTs loaded (eventually) as expected in the NFT tab. ✅

Windows dll error on fresh system also persists with builds from latest CI run https://github.com/KomodoPlatform/komodo-wallet/actions/runs/15138489821

smk762 · 2025-05-21T14:41:36Z

Fee displays as orders of magnitude greater than actual. Withdraw was successful though, with a fee closer to 0.033 ATOM
No IBC option for tendermint withdraw?
opened Withdrawal confirmations are lacking detail #2644 for some related, non-blocking UX improvements.

Note: This should be retested in #2628 also

GLEECBTC/komodo-defi-sdk-flutter#60

smk762

IIRC, dll error issue has been pushed for a different commit.
I added #2679 and #2680, which are non-blocking but should be included in the next release.
I was able to activate IBC assets ✅
I was able to withdraw Tendermint funds, with correctly displayed fees ✅

I was unable to test IBC withdraw until #2679 is resolved, but I have no reason to think it wouldn't if the inputs were present, and the core issue of incompatible task withdraw rpc on tendermint has been resolved.

fix: fix SDK roll CI script issues

512dbc2

- Fix SDK roll CI script issues - Roll SDK version

CharlVS requested a review from smk762 May 16, 2025 08:57

CharlVS self-assigned this May 16, 2025

CharlVS added P0 Blocker / critical defect QA Ready for QA Testing labels May 16, 2025

CharlVS and others added 2 commits May 16, 2025 12:14

CI Test #1

27dceff

build: update remaining SDK commit refs in lockfiles

1861779

CharlVS and others added 2 commits May 17, 2025 14:25

CI Test 2

5648e20

fix(icon-pre-caching): exclude excluded assets to remove NFT_ coins

839c6dc

`NFT_` prefixed coins do not have icons and should not be shown to users, so filter them out from the icon pre-caching

chore: roll SDK

6d5a93d

smk762 requested review from AndrewDelaney and ShantanuSharma9873 May 21, 2025 13:40

chore(deps): upgrade SDK to include fee info fix

07ef77d

GLEECBTC/komodo-defi-sdk-flutter#60

CharlVS requested a review from takenagain May 22, 2025 11:21

This was linked to issues May 22, 2025

Unable to activate IBC assets #2573

Closed

Unable to withdraw IRIS #2572

Closed

smk762 approved these changes May 22, 2025

View reviewed changes

CharlVS merged commit 9830a0f into dev May 22, 2025
9 of 13 checks passed

CharlVS deleted the chore/sdk-roll-kdf-v2.4.0-beta branch May 22, 2025 12:18

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix(sdk): Apply SDK fix for coins bug and KDF release update #2637

fix(sdk): Apply SDK fix for coins bug and KDF release update #2637

Uh oh!

CharlVS commented May 16, 2025 •

edited

Loading

Uh oh!

coderabbitai bot commented May 16, 2025

Review skipped

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

Uh oh!

github-actions bot commented May 16, 2025 •

edited

Loading

Uh oh!

smk762 commented May 16, 2025

Uh oh!

smk762 commented May 21, 2025 •

edited

Loading

Uh oh!

smk762 commented May 21, 2025

Uh oh!

smk762 left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

fix(sdk): Apply SDK fix for coins bug and KDF release update #2637

fix(sdk): Apply SDK fix for coins bug and KDF release update #2637

Uh oh!

Conversation

CharlVS commented May 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changes:

Roll SDK version which includes:

KW repo changes:

Potentially solves (@smk762 please confirm):

Uh oh!

coderabbitai bot commented May 16, 2025

Review skipped

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

github-actions bot commented May 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

smk762 commented May 16, 2025

Uh oh!

smk762 commented May 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

smk762 commented May 21, 2025

Uh oh!

smk762 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

CharlVS commented May 16, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)

github-actions bot commented May 16, 2025 •

edited

Loading

smk762 commented May 21, 2025 •

edited

Loading