chore(re-land release): 0.9.1 reenable Dex #2783
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* fix pwd validation fail on hidden wallet * fix default pass & ensure auto active coins register * use secure random password * refactor: migrate password generation to SDK --------- Co-authored-by: CharlVS <[email protected]>
* fix(trezor): persist generated password and login in HD mode * chore(deps): update SDK to f63bebb * refactor(trezor): add error handling to password storage & retrieval
…d UX (#2771) - Restructure wallet page with tab-based navigation (Assets, Portfolio Growth, Profit & Loss) - Replace single scroll view with NestedScrollView for better tab content management - Move portfolio charts from overlay to dedicated tabs for clearer organization - Enhance mobile coin list items with dedicated balance/24h change layout - Add statistics carousel for mobile wallet overview replacing wrap layout - Integrate 24h price tracking across coin items and portfolio calculations - Update wallet overview with real-time balance and copy functionality - Improve responsive design with platform-specific padding and layouts - Refactor CoinListView into separate widget for cleaner code structure - Change "Currency" header to "Portfolio" and update action button text BREAKING CHANGE: PortfolioGrowthChartLoadSuccess state now requires totalBalance, totalChange24h, and percentageChange24h parameters
* feat: re-enable DEX and Bitrefill * feat: HD support for Bitrefill (WIP) @takenagain, please follow up with thorough testing and run-through using your Bitrefill credentials. I do not have credentials so I was unable to test. * chore: roll SDK * fix: fix minor linting errors Fix minor linting errors. No functional changes. * fix: minor fixes * chore: disable Bitrefill Disable Bitrefill * fix: roll SDK for refreshed build checksums Roll SDK version for updated KDF checksums caused by CI re-run. No functional changes. * chore: roll SDK for p2p fix * fix: change trading status to fail-closed Change trading status to fail-closed and re-check every 10 seconds if * fix: bug in mobile layout of bottom navigation bar * feat: show trading and order-book screens for bounced users * chore: roll SDK Roll SDK for ETH activation fix and to revert v2 trading protocol changes
Contributor
|
Caution Review failedThe pull request is closed. """ WalkthroughThis update introduces a new trading status feature using Changes
Sequence Diagram(s)sequenceDiagram
participant UI
participant TradingStatusBloc
participant TradingStatusRepository
participant API
UI->>TradingStatusBloc: Dispatch TradingStatusCheckRequested
TradingStatusBloc->>TradingStatusRepository: isTradingEnabled()
TradingStatusRepository->>API: HTTP GET /bouncer (or /blacklist)
API-->>TradingStatusRepository: HTTP 200/other
TradingStatusRepository-->>TradingStatusBloc: true/false
TradingStatusBloc-->>UI: Emit TradingEnabled/TradingDisabled state
UI-->>UI: Enable/disable trading buttons, show tooltips
sequenceDiagram
participant User
participant BitrefillButton
participant CoinAddressesBloc
participant BitrefillBloc
User->>BitrefillButton: Press button
BitrefillButton->>CoinAddressesBloc: Get addresses
alt Multiple addresses
BitrefillButton->>User: Show address selection dialog
User-->>BitrefillButton: Select address
end
BitrefillButton->>BitrefillBloc: Dispatch BitrefillLoadRequested(refundAddress)
sequenceDiagram
participant UI
participant TrezorInitBloc
participant FlutterSecureStorage
UI->>TrezorInitBloc: Login to Trezor wallet
TrezorInitBloc->>FlutterSecureStorage: Read password
alt Password not found
TrezorInitBloc->>FlutterSecureStorage: Generate & store new password
end
TrezorInitBloc-->>UI: Proceed with login using password
Possibly related PRs
Suggested labels
Suggested reviewers
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI ⛔ Files ignored due to path filters (3)
📒 Files selected for processing (62)
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
CharlVS
changed the title
|
Visit the preview URL for this PR (updated for commit 617fe36): https://walletrc--pull-2783-merge-vcayk7w5.web.app (expires Mon, 23 Jun 2025 12:38:06 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: f66a4ff03faa546f12f0ae5a841bd9eff2714dcc |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Komodo Wallet v0.9.1 Release Notes
This release re-enables trading functionality, introduces enhanced Bitrefill integration (previously disabled), and includes comprehensive UI improvements, as well as security-focused dependency updates with Flutter API migrations.
✨ New Features
🔄 Trading Functionality Re-enabled
🏪 Enhanced Bitrefill Integration (Disabled)
isBitrefillIntegrationEnabled = false)🔄 Improvements
🎨 User Interface Overhaul
Expandedlayout for consistent spacing🔧 Flutter API Migration
CardTheme→CardThemeDataDialogTheme→DialogThemeDataTabBarTheme→TabBarThemeData🌐 Localization
sellCrypto,sellCryptoDescription,tradingDisabledTooltip,tradingDisabled📦 Dependency Updates & OPSEC Summary
🔒 Security Assessment
All dependency updates have been reviewed for security implications:
Internal (KomodoPlatform) - ✅ Trusted Source
komodo-defi-sdk-flutterpackages (f63bebb02→55176e13b)komodo_coin_updatesv1.0.0Flutter/Dart Team - ✅ Official Maintainer
flutter_plugin_android_lifecycle: 2.0.27 → 2.0.28local_auth_android: 1.0.48 → 1.0.49path_provider_android: 2.2.16 → 2.2.17shared_preferences_android: 2.4.9 → 2.4.10html: 0.15.5+1 → 0.15.6Third-Party - ✅ Established Maintainers
provider: 6.1.4 → 6.1.5 (Remi Rousselet - Flutter community leader)win32: 5.12.0 → 5.13.0 (Microsoft-sponsored Windows API bindings)decimal: 3.2.1 → 3.2.2 (Mathematical precision library)very_good_analysisv8.0.0 (Very Good Ventures - established Flutter consultancy)🔍 OPSEC Review Resources
pubspec.lockfor exact dependency resolutiondart pub audit- no vulnerabilities detected🍎 iOS Development
kIsWalletOnlyconstant - useTradingStatusBloc.state.isEnabledinstead🔧 Technical Changes
TradingStatusState.isEnabledgetter for simplified checkskShowTradingWarningflag for display controls📝 Notes
OPSEC Team: Please review the provided diff links and changelogs before approving release deployment.
Full Changelog: 0.9.0...0.9.1
Summary by CodeRabbit
Summary by CodeRabbit
New Features
Bug Fixes
Chores