-
Notifications
You must be signed in to change notification settings - Fork 240
feat(settings): persist hide zero balance assets #2949
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
|
Visit the preview URL for this PR (updated for commit 2d4e024): https://walletrc--pull-2949-merge-ikmo7olb.web.app (expires Mon, 28 Jul 2025 09:38:06 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: f66a4ff03faa546f12f0ae5a841bd9eff2714dcc |
The selection also persists when I import a second wallet and log in to it, so it appears that the persistence is global, not login specific. Would it be possible to do login based rather than global persistence? If required changes are large, we can delegate this to an issue for future enhancement (e.g. a wallet level toggle persistence system for all in app toggles). |
smk762
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Latest commit does not appear to limit toggle state changes to the logged in wallet only. Changes to one login, appear to persist after logout and login with a different wallet.
This can be moved to issue and approval granted as it is not a blocker and should not delay release.
Thanks. Please do. I will revert the last changes since it may need deeper consideration to get it working smoothly. |
This reverts commit 4d922ae.
Summary
Testing
flutter analyzehttps://chatgpt.com/codex/tasks/task_e_68792bd9c88883268186b34ef8e1294a