-
Notifications
You must be signed in to change notification settings - Fork 240
feat(wallet): HD & offline private key export + unban pubkeys #2982
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Roll SDK for overhauled privkey export in KDF branch `offline_key_export` and implement privkey methods into SDK
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
|
Visit the preview URL for this PR (updated for commit 2bb9a4d): https://walletrc--pull-2982-merge-kl5rm3ui.web.app (expires Wed, 06 Aug 2025 19:28:58 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: f66a4ff03faa546f12f0ae5a841bd9eff2714dcc |
…into add/hd-privkey-export
…into add/hd-privkey-export
Remove redundant pubkey unban control in the general settings page since it is also in the security settings page.
|
UX Enhancement Currently the private keys are shown on their own. This was ok in non-HD mode, as it was clear that the single private key related to the single address for a coin in your wallet. Since we've introduced HD, it is less obvious which private key links to which address. Though the derivation path is shown, casual users are unlikely to understand this. To improve the UX in this page, I suggest that alongside the private key, we include the address (at minimum). Including the pubkey might come in handy, if space is available. The derivation path should be retained in view. |
|
confirmed privkey export not accessible in Trezor mode ✅ |
@smk762, please re-test this - I've pushed a fix. I've also included the address/pubkey in the UI as requested.
The KDF team has confirmed that they will address it in
Please open an issue. |
Display a tooltip for the sparkline chart so users can understand what the data represents, considering that we no longer display table headings.
Roll SDK for address generation errors
smk762
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Confirmed blocker resolved. HT now returns privkeys despite failure to activate 🎉
Addresses for each privkey now also visible which was primary UX concern. Other comments will be converted to issue for next release.
Delete HD-related types. Previous references have likely been migrated to the SDK types. TODO: Investigate if there are any other similar cases.
* chore: roll sdk for overhauled privkey export Roll SDK for overhauled privkey export in KDF branch `offline_key_export` and implement privkey methods into SDK * chore: roll SDK * wip: settings private key export * chore: roll sdk * chore: roll SDK * fix(ui): polish private key export * chore: roll SDK * fix(lint): fix lint warning * fix: minor private key fixes * feat(ui): Simplify/polish private key export * feat: pubkey unbanning * refactor: clean up pubkey unbanning * fix: remove duplicate pubkey unbanning message * fix(ui): Enforce max scaffold message width for unbanning * fix(ui): Remove redundant pubkey unban control Remove redundant pubkey unban control in the general settings page since it is also in the security settings page. * refactor: make password confirmation re-usable * fix(password): allow auto-fill for password confirmation * feat: password manager integration for password confirmation * chore: roll SDK for pubkey unban fix * chore: roll SDK * fix: include failed activations in privkey export * fix(ui): show tooltip for sparkline chart Display a tooltip for the sparkline chart so users can understand what the data represents, considering that we no longer display table headings. * chore: roll SDK Roll SDK for address generation errors * chore: delete unused types Delete HD-related types. Previous references have likely been migrated to the SDK types. TODO: Investigate if there are any other similar cases. * chore: roll SDK
git status q git config --list | grep -E "(rebase|pull|push)" at(wallet): HD & offline private key export + unban pubkeys (#2982) * chore: roll sdk for overhauled privkey export Roll SDK for overhauled privkey export in KDF branch `offline_key_export` and implement privkey methods into SDK * chore: roll SDK * wip: settings private key export * chore: roll sdk * chore: roll SDK * fix(ui): polish private key export * chore: roll SDK * fix(lint): fix lint warning * fix: minor private key fixes * feat(ui): Simplify/polish private key export * feat: pubkey unbanning * refactor: clean up pubkey unbanning * fix: remove duplicate pubkey unbanning message * fix(ui): Enforce max scaffold message width for unbanning * fix(ui): Remove redundant pubkey unban control Remove redundant pubkey unban control in the general settings page since it is also in the security settings page. * refactor: make password confirmation re-usable * fix(password): allow auto-fill for password confirmation * feat: password manager integration for password confirmation * chore: roll SDK for pubkey unban fix * chore: roll SDK * fix: include failed activations in privkey export * fix(ui): show tooltip for sparkline chart Display a tooltip for the sparkline chart so users can understand what the data represents, considering that we no longer display table headings. * chore: roll SDK Roll SDK for address generation errors * chore: delete unused types Delete HD-related types. Previous references have likely been migrated to the SDK types. TODO: Investigate if there are any other similar cases. * chore: roll SDK
* chore: roll sdk for overhauled privkey export Roll SDK for overhauled privkey export in KDF branch `offline_key_export` and implement privkey methods into SDK * chore: roll SDK * wip: settings private key export * chore: roll sdk * chore: roll SDK * fix(ui): polish private key export * chore: roll SDK * fix(lint): fix lint warning * fix: minor private key fixes * feat(ui): Simplify/polish private key export * feat: pubkey unbanning * refactor: clean up pubkey unbanning * fix: remove duplicate pubkey unbanning message * fix(ui): Enforce max scaffold message width for unbanning * fix(ui): Remove redundant pubkey unban control Remove redundant pubkey unban control in the general settings page since it is also in the security settings page. * refactor: make password confirmation re-usable * fix(password): allow auto-fill for password confirmation * feat: password manager integration for password confirmation * chore: roll SDK for pubkey unban fix * chore: roll SDK * fix: include failed activations in privkey export * fix(ui): show tooltip for sparkline chart Display a tooltip for the sparkline chart so users can understand what the data represents, considering that we no longer display table headings. * chore: roll SDK Roll SDK for address generation errors * chore: delete unused types Delete HD-related types. Previous references have likely been migrated to the SDK types. TODO: Investigate if there are any other similar cases. * chore: roll SDK
* chore: roll sdk for overhauled privkey export Roll SDK for overhauled privkey export in KDF branch `offline_key_export` and implement privkey methods into SDK * chore: roll SDK * wip: settings private key export * chore: roll sdk * chore: roll SDK * fix(ui): polish private key export * chore: roll SDK * fix(lint): fix lint warning * fix: minor private key fixes * feat(ui): Simplify/polish private key export * feat: pubkey unbanning * refactor: clean up pubkey unbanning * fix: remove duplicate pubkey unbanning message * fix(ui): Enforce max scaffold message width for unbanning * fix(ui): Remove redundant pubkey unban control Remove redundant pubkey unban control in the general settings page since it is also in the security settings page. * refactor: make password confirmation re-usable * fix(password): allow auto-fill for password confirmation * feat: password manager integration for password confirmation * chore: roll SDK for pubkey unban fix * chore: roll SDK * fix: include failed activations in privkey export * fix(ui): show tooltip for sparkline chart Display a tooltip for the sparkline chart so users can understand what the data represents, considering that we no longer display table headings. * chore: roll SDK Roll SDK for address generation errors * chore: delete unused types Delete HD-related types. Previous references have likely been migrated to the SDK types. TODO: Investigate if there are any other similar cases. * chore: roll SDK
* chore: roll sdk for overhauled privkey export Roll SDK for overhauled privkey export in KDF branch `offline_key_export` and implement privkey methods into SDK * chore: roll SDK * wip: settings private key export * chore: roll sdk * chore: roll SDK * fix(ui): polish private key export * chore: roll SDK * fix(lint): fix lint warning * fix: minor private key fixes * feat(ui): Simplify/polish private key export * feat: pubkey unbanning * refactor: clean up pubkey unbanning * fix: remove duplicate pubkey unbanning message * fix(ui): Enforce max scaffold message width for unbanning * fix(ui): Remove redundant pubkey unban control Remove redundant pubkey unban control in the general settings page since it is also in the security settings page. * refactor: make password confirmation re-usable * fix(password): allow auto-fill for password confirmation * feat: password manager integration for password confirmation * chore: roll SDK for pubkey unban fix * chore: roll SDK * fix: include failed activations in privkey export * fix(ui): show tooltip for sparkline chart Display a tooltip for the sparkline chart so users can understand what the data represents, considering that we no longer display table headings. * chore: roll SDK Roll SDK for address generation errors * chore: delete unused types Delete HD-related types. Previous references have likely been migrated to the SDK types. TODO: Investigate if there are any other similar cases. * chore: roll SDK
* chore: roll sdk for overhauled privkey export Roll SDK for overhauled privkey export in KDF branch `offline_key_export` and implement privkey methods into SDK * chore: roll SDK * wip: settings private key export * chore: roll sdk * chore: roll SDK * fix(ui): polish private key export * chore: roll SDK * fix(lint): fix lint warning * fix: minor private key fixes * feat(ui): Simplify/polish private key export * feat: pubkey unbanning * refactor: clean up pubkey unbanning * fix: remove duplicate pubkey unbanning message * fix(ui): Enforce max scaffold message width for unbanning * fix(ui): Remove redundant pubkey unban control Remove redundant pubkey unban control in the general settings page since it is also in the security settings page. * refactor: make password confirmation re-usable * fix(password): allow auto-fill for password confirmation * feat: password manager integration for password confirmation * chore: roll SDK for pubkey unban fix * chore: roll SDK * fix: include failed activations in privkey export * fix(ui): show tooltip for sparkline chart Display a tooltip for the sparkline chart so users can understand what the data represents, considering that we no longer display table headings. * chore: roll SDK Roll SDK for address generation errors * chore: delete unused types Delete HD-related types. Previous references have likely been migrated to the SDK types. TODO: Investigate if there are any other similar cases. * chore: roll SDK
* chore: roll sdk for overhauled privkey export Roll SDK for overhauled privkey export in KDF branch `offline_key_export` and implement privkey methods into SDK * chore: roll SDK * wip: settings private key export * chore: roll sdk * chore: roll SDK * fix(ui): polish private key export * chore: roll SDK * fix(lint): fix lint warning * fix: minor private key fixes * feat(ui): Simplify/polish private key export * feat: pubkey unbanning * refactor: clean up pubkey unbanning * fix: remove duplicate pubkey unbanning message * fix(ui): Enforce max scaffold message width for unbanning * fix(ui): Remove redundant pubkey unban control Remove redundant pubkey unban control in the general settings page since it is also in the security settings page. * refactor: make password confirmation re-usable * fix(password): allow auto-fill for password confirmation * feat: password manager integration for password confirmation * chore: roll SDK for pubkey unban fix * chore: roll SDK * fix: include failed activations in privkey export * fix(ui): show tooltip for sparkline chart Display a tooltip for the sparkline chart so users can understand what the data represents, considering that we no longer display table headings. * chore: roll SDK Roll SDK for address generation errors * chore: delete unused types Delete HD-related types. Previous references have likely been migrated to the SDK types. TODO: Investigate if there are any other similar cases. * chore: roll SDK


This pull request introduces enhancements to the security settings flow, focusing on private key management and pubkey unbanning. It also includes updates to UI components and localization strings. The most significant changes are grouped into themes: private key management, seed phrase handling, and UI improvements.
Private Key Management Enhancements:
lib/bloc/security_settings/security_settings_bloc.dart,lib/bloc/security_settings/security_settings_event.dart,lib/bloc/security_settings/security_settings_state.dart) [1] [2] [3]SecuritySettingsStep.privateKeyShowto represent private key export in the flow. (lib/bloc/security_settings/security_settings_state.dart)Seed Phrase Handling:
lib/bloc/security_settings/security_settings_bloc.dart,lib/bloc/security_settings/security_settings_event.dart) [1] [2]assets/translations/en.json)UI Improvements:
lib/views/common/wallet_password_dialog/password_dialog_content.dart)assets/translations/en.json)These changes collectively enhance the security settings flow, improve user experience, and ensure sensitive data is handled securely.