Skip to content

Conversation

@smk762
Copy link
Collaborator

@smk762 smk762 commented Oct 29, 2025

closes #3294

image

To test:

  • Login to as funded wallet
  • Enter a funded coin page
  • Prepare a withdrawal for the full amount of the address balance, without using the max input field
  • See confirmation pop up appear
  • if cancel, see withdraw error message (same as previous)
  • if confirm, see withdraw confirmation details
  • confirm transaction sends successfully

I've tested this with LTC, ATOM and MATIC in web, please check a diverse set of coins to confirm.


Note

When a manual withdrawal equals the spendable balance and preview fails, show a confirmation to switch to Max (deducting fee), auto-retry preview, and temporarily suppress the preview error.

  • Withdraw flow
    • Add listener on previewError to detect manual amount matching spendable (with epsilon) and prompt user to switch to Max (fee deducted).
      • On confirm: dispatch WithdrawFormMaxAmountEnabled(true) and re-submit preview.
      • Temporarily suppress preview error display while dialog is shown.
    • Propagate suppressPreviewError through WithdrawFormContentWithdrawFormFillSection and gate ErrorDisplay with it.
    • Use decimal for precise amount comparison.

Written by Cursor Bugbot for commit 62cfea1. This will update automatically on new commits. Configure here.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Oct 29, 2025

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Note

Other AI code review bot(s) detected

CodeRabbit has detected other AI code review bot(s) in this pull request and will avoid duplicating their findings in the review comments. This may lead to a less comprehensive review.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch handle-manual-max-withdraw

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@smk762 smk762 requested a review from DeckerSU October 29, 2025 12:26
@smk762 smk762 self-assigned this Oct 29, 2025
@github-actions
Copy link

github-actions bot commented Oct 29, 2025

Visit the preview URL for this PR (updated for commit 0081528):

https://walletrc--pull-3296-merge-hgrmur1q.web.app

(expires Sun, 30 Nov 2025 07:52:54 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: f66a4ff03faa546f12f0ae5a841bd9eff2714dcc

@smk762 smk762 added P1 Major issue needs to be fixed UX Cosmetic or flow efficiency enhancements for improved User Experience labels Oct 29, 2025
Copy link
Collaborator

@takenagain takenagain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed on web with DOGE, AVAX, ARRR, USDT-BEP20, and IRIS

cursor[bot]

This comment was marked as outdated.

@CharlVS CharlVS added this to the v0.9.3 Release milestone Nov 2, 2025
@cursor
Copy link

cursor bot commented Nov 2, 2025

Cursor Agent can help with this pull request. Just @cursor in comments and I'll start working on changes in this branch.
Learn more about Cursor Agents

CharlVS added a commit that referenced this pull request Nov 2, 2025
@smk762 smk762 modified the milestones: v0.9.3 Release, v0.9.4 Nov 5, 2025
@smk762 smk762 merged commit 6170a7d into dev Nov 23, 2025
6 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

P1 Major issue needs to be fixed UX Cosmetic or flow efficiency enhancements for improved User Experience

Projects

None yet

Development

Successfully merging this pull request may close these issues.

When trying to withdraw the max amount, ask if it's ok to deduct fee from the input amount

5 participants