-
Notifications
You must be signed in to change notification settings - Fork 240
add user confirm for manual withdraw input when equivalent to max #3296
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Note Other AI code review bot(s) detectedCodeRabbit has detected other AI code review bot(s) in this pull request and will avoid duplicating their findings in the review comments. This may lead to a less comprehensive review. ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Visit the preview URL for this PR (updated for commit 0081528): https://walletrc--pull-3296-merge-hgrmur1q.web.app (expires Sun, 30 Nov 2025 07:52:54 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: f66a4ff03faa546f12f0ae5a841bd9eff2714dcc |
takenagain
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Confirmed on web with DOGE, AVAX, ARRR, USDT-BEP20, and IRIS
Co-authored-by: charl <[email protected]>
|
Cursor Agent can help with this pull request. Just |
… input when equivalent to max (v0.9.3)
closes #3294
To test:
maxinput fieldI've tested this with LTC, ATOM and MATIC in web, please check a diverse set of coins to confirm.
Note
When a manual withdrawal equals the spendable balance and preview fails, show a confirmation to switch to Max (deducting fee), auto-retry preview, and temporarily suppress the preview error.
previewErrorto detect manual amount matching spendable (with epsilon) and prompt user to switch toMax(fee deducted).WithdrawFormMaxAmountEnabled(true)and re-submit preview.suppressPreviewErrorthroughWithdrawFormContent→WithdrawFormFillSectionand gateErrorDisplaywith it.decimalfor precise amount comparison.Written by Cursor Bugbot for commit 62cfea1. This will update automatically on new commits. Configure here.