Skip to content

Update build system for external plugins#1578

Merged
rbuels merged 5 commits intomasterfrom
external_plugin_updates
Dec 23, 2020
Merged

Update build system for external plugins#1578
rbuels merged 5 commits intomasterfrom
external_plugin_updates

Conversation

@garrettjstevens
Copy link
Copy Markdown
Collaborator

After talking with @rbuels, this PR removes support for previous webpack-built plugins and switches over to using TSDX (ref).

There's a template with information in the README about how to use it here: https://github.com/GMOD/jbrowse-plugin-template. (The template is private for now, would be made public on merge of this)

Also adds a couple notes in the docs about this.

I've got a PR going for switching the GDC plugin to this. I could also put in PRs for other plugins if wanted (https://github.com/cmdcolin/jbrowse-plugin-biothings-api and https://github.com/cmdcolin/jbrowse-plugin-ucsc-api are mentioned in the docs, are there others we should update?).

There's a bug relating to build naming in the current version of TSDX that gets fixed with patch-package (see jaredpalmer/tsdx#669), and when that bug gets fixed we can then update development-tools to not use patch-package and end users shouldn't notice any difference.

@garrettjstevens garrettjstevens self-assigned this Dec 21, 2020
@cmdcolin
Copy link
Copy Markdown
Collaborator

removes support for previous webpack-built plugins

What causes this?

@garrettjstevens
Copy link
Copy Markdown
Collaborator Author

removes support for previous webpack-built plugins

What causes this?

Two things:

  1. On webworker, global stuff is on self instead of self.window
  2. Removes the webpack config from @jbrowse/development-tools

@codecov
Copy link
Copy Markdown

codecov bot commented Dec 22, 2020

Codecov Report

Merging #1578 (0313182) into master (69e98e4) will decrease coverage by 0.04%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1578      +/-   ##
==========================================
- Coverage   59.51%   59.47%   -0.05%     
==========================================
  Files         435      434       -1     
  Lines       19565    19549      -16     
  Branches     4568     4566       -2     
==========================================
- Hits        11645    11627      -18     
- Misses       7626     7628       +2     
  Partials      294      294              
Impacted Files Coverage Δ
packages/core/PluginLoader.ts 25.64% <0.00%> (-2.14%) ⬇️
packages/core/ReExports/modules.ts 75.00% <ø> (ø)
products/jbrowse-web/src/rpc.worker.ts 22.03% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 69e98e4...0313182. Read the comment docs.

@rbuels
Copy link
Copy Markdown
Contributor

rbuels commented Dec 22, 2020

this removal of the webpack stuff is a breaking change, but I feel that instability is probably OK because it's early days still

@rbuels rbuels merged commit 5d3419e into master Dec 23, 2020
@rbuels rbuels deleted the external_plugin_updates branch December 23, 2020 17:09
@garrettjstevens garrettjstevens mentioned this pull request Jan 4, 2021
@garrettjstevens garrettjstevens added needs label triage Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal) breaking and removed needs label triage Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal) labels Jan 6, 2021
@garrettjstevens garrettjstevens changed the title External plugin updates Update build system for external plugins Jan 6, 2021
@garrettjstevens garrettjstevens added enhancement New feature or request and removed breaking labels Jan 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants