Update build system for external plugins#1578
Merged
Conversation
Collaborator
What causes this? |
Collaborator
Author
Two things:
|
Codecov Report
@@ Coverage Diff @@
## master #1578 +/- ##
==========================================
- Coverage 59.51% 59.47% -0.05%
==========================================
Files 435 434 -1
Lines 19565 19549 -16
Branches 4568 4566 -2
==========================================
- Hits 11645 11627 -18
- Misses 7626 7628 +2
Partials 294 294
Continue to review full report at Codecov.
|
Contributor
|
this removal of the webpack stuff is a breaking change, but I feel that instability is probably OK because it's early days still |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After talking with @rbuels, this PR removes support for previous webpack-built plugins and switches over to using TSDX (ref).
There's a template with information in the README about how to use it here: https://github.com/GMOD/jbrowse-plugin-template. (The template is private for now, would be made public on merge of this)
Also adds a couple notes in the docs about this.
I've got a PR going for switching the GDC plugin to this. I could also put in PRs for other plugins if wanted (https://github.com/cmdcolin/jbrowse-plugin-biothings-api and https://github.com/cmdcolin/jbrowse-plugin-ucsc-api are mentioned in the docs, are there others we should update?).
There's a bug relating to build naming in the current version of TSDX that gets fixed with
patch-package(see jaredpalmer/tsdx#669), and when that bug gets fixed we can then updatedevelopment-toolsto not usepatch-packageand end users shouldn't notice any difference.