fix(ci): retry libcdb-cache nginx startup until listening#2716
Open
bobo-xxx wants to merge 1 commit intoGallopsled:devfrom
Open
fix(ci): retry libcdb-cache nginx startup until listening#2716bobo-xxx wants to merge 1 commit intoGallopsled:devfrom
bobo-xxx wants to merge 1 commit intoGallopsled:devfrom
Conversation
The nginx cache container sometimes fails to start after 'docker restart' because Docker's embedded DNS (127.0.0.11) is not yet ready when nginx validates its upstream hostnames, causing 'host not found in upstream' errors. This is a race condition that manifests as intermittent CI flakiness. The fix adds: - A fallback filter to find the container by name if the volume filter does not match (for reliability across Docker versions). - A retry loop that polls nginx every 3 seconds until it is listening on the cache ports (3000-3004), restarting nginx if it is not up. - Clear error reporting with docker logs if nginx fails to start after 10 attempts. Fixes Gallopsled#2712.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The nginx cache container sometimes fails to start after 'docker restart' because Docker's embedded DNS (127.0.0.11) is not yet ready when nginx validates its upstream hostnames, causing 'host not found in upstream' errors. This is a race condition that manifests as intermittent CI flakiness.
The fix adds:
Fixes #2712.