-
Notifications
You must be signed in to change notification settings - Fork 663
Closed
Description
Running some regression tests against master version 3.beta-1 and found that GitVersion will use IP-numbers in our merge commits as versions. MergeMessageBaseVersionStrategy is really powerful but also a little bit dangerous.
[Test]
public void AMergeCommitIncludingAnIpNumberShouldNotBeParsedAsAVersion()
{
var mergeCommitWithIpNumber = @"Merge pull request #45 in BRIKKS/brikks from feature/NOX-68 to develop
* commit '38560a7eed06e8d3f3f1aaf091befcdf8bf50fea':
Another commit message
Commit message including a IP-number https://10.50.1.1
A commit message";
var parents = GetParents(true);
AssertMergeMessage(mergeCommitWithIpNumber, null, parents);
}Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
No labels