Skip to content

IP nummer in merge messages is treated as versions #395

@orjan

Description

@orjan

Running some regression tests against master version 3.beta-1 and found that GitVersion will use IP-numbers in our merge commits as versions. MergeMessageBaseVersionStrategy is really powerful but also a little bit dangerous.

        [Test]
        public void AMergeCommitIncludingAnIpNumberShouldNotBeParsedAsAVersion()
        {
            var mergeCommitWithIpNumber = @"Merge pull request #45 in BRIKKS/brikks from feature/NOX-68 to develop

* commit '38560a7eed06e8d3f3f1aaf091befcdf8bf50fea':
  Another commit message
  Commit message including a IP-number https://10.50.1.1
  A commit message";

            var parents = GetParents(true);

            AssertMergeMessage(mergeCommitWithIpNumber, null, parents);
        }

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions