Preserve existing file encoding if it can be easily determined otherwise use UTF8 with BOM.#1149
Preserve existing file encoding if it can be easily determined otherwise use UTF8 with BOM.#1149JakeGinnivan merged 1 commit intoGitTools:masterfrom kll:feature/preserve_encoding
Conversation
|
At the moment it looks like the travis-ci MacOS queue is having some issues. |
otherwise use UTF8 with BOM.
|
Yesterday when I submitted the PR the appveyor build passed but the travis-ci build failed due to their MacOS queue issues. Today I nudged the PR to cause a rebuild since travis-ci was back to normal but this time the inverse happened and appveyor failed while travis-ci passed. No code changed and looking at the log everything built and it shows 431 tests passed, 0 failed, 0 warnings, 0 inconclusive, 0 skipped. It just looks like NUnit3 crashed. |
|
Seems like the problem is this: Perhaps upgrading NUnit can help? |
|
I don't know, maybe it will, but why did it run and pass the day before? It also runs and passes fine when I run the build locally. I suspect something transient on the appveyor server and if it was just run again it would probably pass. |
|
@kll: Ok, I've restarted the build. Let's see how it goes. |
This fixes #1074 and will no longer strip the BOM or change the encoding when a file has a BOM. It does not handle cases where a BOM was not included or the existing encoding was not Unicode based. In those cases the files will be written using UTF8 with BOM as that is the most common and complies with StyleCop SA1412