VsoAgentBuildNumberTests refactored with accordance to the remark from @asbjornu#1260
Merged
JakeGinnivan merged 6 commits intoGitTools:masterfrom Dec 5, 2017
dpurge:bugfix/1257
Merged
VsoAgentBuildNumberTests refactored with accordance to the remark from @asbjornu#1260JakeGinnivan merged 6 commits intoGitTools:masterfrom dpurge:bugfix/1257
JakeGinnivan merged 6 commits intoGitTools:masterfrom
dpurge:bugfix/1257
Conversation
asbjornu
requested changes
Jul 12, 2017
Member
asbjornu
left a comment
asbjornu
left a comment
There was a problem hiding this comment.
Looking good! Just a minor nit and it LGTM!
| VsoAgent versionBuilder = new VsoAgent(); | ||
|
|
||
| [SetUp] | ||
| public void SetUpVsoAgentBuildNumberTest() |
Member
There was a problem hiding this comment.
The SetUp method can probably be removed now, no?
Contributor
Author
|
Empty test setup method removed. |
asbjornu
approved these changes
Jul 13, 2017
Member
|
Hm, did I forget to merge this? I've been on a holiday so I can't really remember what the story was here. Why did you close the PR, @dpurge? |
Contributor
Author
|
By mistake :) I removed the branch from my fork. I have restored the branch and I am re-opening pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No functional changes - test refactored in accordance to the sugestion from @asbjornu