Fixes #380 but on 3.0 branch#382
Fixes #380 but on 3.0 branch#382johannesegger wants to merge 3 commits intoGitTools:release/3.0.0from johannesegger:release/3.0.0
Conversation
|
This looks great, thanks! Thought it can't be merged automatically. If you would like to fix this yourself (not sure how familiar you are with git) steps below, otherwise I will merge manually tonight or tomorrow. If you are unsure what rebase does, check out http://onlywei.github.io/explain-git-with-d3/#rebase - it is super handy. Then my workflow when doing things normally is: Then I am ready to go on an updated feature branch. As I said, feel free to do this or not. Just posted in case it is helpful to you |
|
Yeah I'm good with git. I was using a colleagues account at work. I should have created you a feature branch ( we use git flow at work. Was just being lazy getting the quick fix done. ) However I won't be able to do the rebase until 7am tomorrow GMT+1. I'll check tomorrow and see if it's done or not. Thanks for the neat tool. That and git flow are making our release process a bit less of a nightmare :) |
|
Thought that would be the case, could probably assume that with most PR's on this project but always like to make sure. I found it helpful when starting out with git and figuring workflows. |
Ok made the fix on the 3.0 branch for merging