cleanup code targeting < net8.0#4316
Merged
arturcic merged 1 commit intoGitTools:mainfrom Nov 17, 2024
Merged
Conversation
Contributor
|
Thank you @arturcic for your contribution! |
Contributor
|
🎉 This issue has been resolved in version 6.1.0 🎉 Your GitReleaseManager bot 📦🚀 |
This was referenced Jul 25, 2025
This was referenced Aug 1, 2025
This was referenced Aug 15, 2025
This was referenced Aug 25, 2025
This was referenced Sep 1, 2025
This was referenced Oct 30, 2025
This was referenced Dec 1, 2025
This was referenced Feb 4, 2026
Closed
This was referenced Feb 16, 2026
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request includes multiple changes to remove conditional compilation for older .NET versions and to ensure compatibility with .NET 8.0 or greater. The most important changes involve the removal of custom attribute definitions and updates to test files.
Removal of Conditional Compilation and Custom Attributes:
src/GitVersion.Core/Polyfills/StringSyntaxAttribute.cs: Removed the customStringSyntaxAttributeclass, which was used to provide compatibility for versions prior to .NET 7.0.Updates to Test Files:
src/GitVersion.Output.Tests/Output/Approved/cs/GitVersionInfoGeneratorTests.ShouldCreateFile.approved.txt: Removed the conditional compilation for theExcludeFromCodeCoverageAttributeclass.src/GitVersion.Output.Tests/Output/Approved/fs/GitVersionInfoGeneratorTests.ShouldCreateFile.approved.txt: Removed the conditional compilation for theExcludeFromCodeCoverageAttributeclass.src/GitVersion.Output.Tests/Output/Approved/vb/GitVersionInfoGeneratorTests.ShouldCreateFile.approved.txt: Removed the conditional compilation for theExcludeFromCodeCoverageAttributeclass.Updates to Template Files:
src/GitVersion.Output/GitVersionInfo/Templates/GitVersionInformation.cs: Removed the conditional compilation for theExcludeFromCodeCoverageAttributeclass.src/GitVersion.Output/GitVersionInfo/Templates/GitVersionInformation.fs: Removed the conditional compilation for theExcludeFromCodeCoverageAttributeclass.src/GitVersion.Output/GitVersionInfo/Templates/GitVersionInformation.vb: Removed the conditional compilation for theExcludeFromCodeCoverageAttributeclass.Miscellaneous:
src/GitVersion.Testing/Helpers/StringBuilderExtensions.cs: Updated theAppendLineFormatmethod to remove conditional compilation for theStringSyntaxattribute.