Pick up GitVersionConfig.yaml when using a dynamic repository#439
Closed
johannesegger wants to merge 1 commit intoGitTools:masterfrom
johannesegger:pick-up-config-in-dynamic-repo
Closed
Pick up GitVersionConfig.yaml when using a dynamic repository#439johannesegger wants to merge 1 commit intoGitTools:masterfrom johannesegger:pick-up-config-in-dynamic-repo
johannesegger wants to merge 1 commit intoGitTools:masterfrom
johannesegger:pick-up-config-in-dynamic-repo
Conversation
… up when using a dynamic repo.
Contributor
|
I have worked through this issue (I think) in #451. Would you be able to have a look @eggapauli ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I implemented a test that shows that
GitVersionConfig.yamlisn't picked up correctly when a dynamic repository is used.In 7c27ad0 you said that the config will be picked up from the original repo. but I think this isn't true since
ConfigurationProvider.GetConfigFilePathis called with the path to the dynamic repository.Checking out
GitVersionConfig.yamlin the dynamic repository is probably the easiest thing to resolve this (you removed this in the above mentioned commit).Or do you have some better idea?