Refactor help and version command handling

[arturcic]

Move help and version output logic from GitVersionApp to ArgumentParser, centralizing command handling. This simplifies the application's main execution flow by delegating output responsibility.

Fixes #4839

[Copilot]

Pull request overview

Centralizes handling of help and version commands by moving their output logic away from the main execution path and into argument parsing, aiming to simplify GitVersionApp/GitVersionExecutor flow.

Changes:

• Removed help/version handling from GitVersionExecutor and refactored initialization logic.
• Added help/version output side effects to ArgumentParser during parsing.
• Short-circuited GitVersionApp execution when IsHelp or IsVersion is set.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File	Description
src/GitVersion.App/GitVersionExecutor.cs	Removes help/version dispatch; introduces Initialize() and always runs the main tool.
src/GitVersion.App/GitVersionApp.cs	Exits early for help/version commands before running the executor.
src/GitVersion.App/ArgumentParser.cs	Writes help/version output during argument parsing and sets corresponding flags.

[Copilot]

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated no new comments.

Comments suppressed due to low confidence (2)

src/GitVersion.App/ArgumentParser.cs:61

• In this primary-constructor class, call this.helpWriter.Write() rather than helpWriter.Write(). Referencing the primary constructor parameter from an instance method can cause it to be captured into a compiler-generated hidden field, duplicating state and adding a small amount of overhead; using the validated private readonly field avoids that.

        {
            helpWriter.Write();
            return new Arguments

src/GitVersion.App/ArgumentParser.cs:70

• Use this.versionWriter.Write(assembly) instead of versionWriter.Write(assembly) so the method uses the initialized field rather than capturing the primary constructor parameter into a hidden compiler field.

        if (firstArgument.IsSwitch("version"))
        {
            var assembly = Assembly.GetExecutingAssembly();
            versionWriter.Write(assembly);

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[Copilot]

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated no new comments.

Comments suppressed due to low confidence (1)

src/GitVersion.App/ArgumentParser.cs:74

• ParseArguments now produces side effects by writing help/version output via IHelpWriter/IVersionWriter. Existing ArgumentParserTests cover -h and -version parsing, but they don't verify the new behavior (that the corresponding writer is invoked and output is produced during parsing). Adding targeted tests (e.g., with a stub console or mocked writer) will prevent regressions where IsHelp/IsVersion is set but no output is emitted.

        if (firstArgument.IsHelp())
        {
            this.helpWriter.Write();
            return new Arguments
            {
                IsHelp = true
            };
        }

        if (firstArgument.IsSwitch("version"))
        {
            var assembly = Assembly.GetExecutingAssembly();
            this.versionWriter.Write(assembly);
            return new Arguments
            {
                IsVersion = true
            };

[mergify]

Thank you @arturcic for your contribution!