Skip to content

On Spot A4#4953

Merged
LAVEEN merged 1 commit intoGoogleCloudPlatform:developfrom
LAVEEN:a4nt
Dec 9, 2025
Merged

On Spot A4#4953
LAVEEN merged 1 commit intoGoogleCloudPlatform:developfrom
LAVEEN:a4nt

Conversation

@LAVEEN
Copy link
Contributor

@LAVEEN LAVEEN commented Dec 8, 2025

Add daily test for A4 GPU Slurm clusters with on-spot VMs

This changelist introduces a new automated daily test to the Cloud Build pipeline. The test validates the deployment and functionality of Slurm clusters configured with A4 Ultra GPUs on on-spot (preemptible) virtual machines.

The purpose of this test is to ensure the reliability of cost-optimized GPU deployments in the HPC Toolkit by regularly verifying the integration of these components.

The new test includes post-deployment validation for the Slurm cluster, covering:

  • GPU partitions
  • File system mounts
  • Enroot setup
  • Default partition configuration

Submission Checklist

NOTE: Community submissions can take up to 2 weeks to be reviewed.

Please take the following actions before submitting this pull request.

  • Fork your PR branch from the Toolkit "develop" branch (not main)
  • Test all changes with pre-commit in a local branch #
  • Confirm that "make tests" passes all tests
  • Add or modify unit tests to cover code changes
  • Ensure that unit test coverage remains above 80%
  • Update all applicable documentation
  • Follow Cluster Toolkit Contribution guidelines #

@LAVEEN LAVEEN requested review from a team and samskillman as code owners December 8, 2025 06:29
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @LAVEEN, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a new automated daily test within the Cloud Build pipeline. The primary purpose of this test is to validate the successful deployment and functionality of Slurm clusters configured with A4 Ultra GPUs, specifically utilizing on-spot (preemptible) virtual machines. This ensures that the HPC Toolkit's capabilities for cost-optimized GPU deployments remain robust and reliable by regularly checking the integration of these components.

Highlights

  • New Daily Test: Introduces a new daily Cloud Build test specifically designed for A4 GPU Slurm clusters.
  • On-Spot VM Validation: The new test focuses on validating the deployment and functionality of A4 GPU clusters utilizing on-spot (preemptible) virtual machines, ensuring cost-optimized deployments work as expected.
  • Slurm Integration and Validation: The test includes comprehensive post-deployment validation steps for the Slurm cluster, covering GPU partitions, file system mounts, Enroot setup, and default partition configuration.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds a new daily integration test for A4 GPUs with Slurm using Spot VMs. The changes introduce new Cloud Build and Ansible configuration files. My review has identified several critical configuration issues that will likely cause the test to fail. These issues seem to stem from copying an existing test configuration without fully updating all variables for the new environment (e.g., partition names, blueprint variables). I have also pointed out several naming inconsistencies that impact code clarity and maintainability. Addressing these comments will ensure the new test is correct, reliable, and easier to maintain.

@LAVEEN LAVEEN force-pushed the a4nt branch 3 times, most recently from 51d4ba3 to bfc42cd Compare December 9, 2025 04:47
@LAVEEN LAVEEN added release-key-new-features Added to release notes under the "Key New Features" heading. release-improvements Added to release notes under the "Improvements" heading. labels Dec 9, 2025
@LAVEEN LAVEEN force-pushed the a4nt branch 2 times, most recently from c78a6d0 to b2903eb Compare December 9, 2025 09:45
@LAVEEN LAVEEN enabled auto-merge December 9, 2025 18:39
@LAVEEN LAVEEN merged commit 88929ae into GoogleCloudPlatform:develop Dec 9, 2025
11 of 66 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release-improvements Added to release notes under the "Improvements" heading. release-key-new-features Added to release notes under the "Key New Features" heading.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants