Adding test for A3 UltraGPU JBVMs with Spot VMs

[simrankaurb]

This PR introduces a new integration test for A3 UltraGPU JBVMs instances using Spot VMs.

The changes include:

• A new Cloud Build configuration (ml-a3-ultragpu-onspot-jbvms.yaml) to run the test.
• A corresponding test definition file (ml-a3-ultragpu-onspot-jbvms.yml) that sets the necessary parameters for the test, such setting the provisioning model to "SPOT"

Submission Checklist

NOTE: Community submissions can take up to 2 weeks to be reviewed.

Please take the following actions before submitting this pull request.

• Fork your PR branch from the Toolkit "develop" branch (not main)
• Test all changes with pre-commit in a local branch #
• Confirm that "make tests" passes all tests
• Add or modify unit tests to cover code changes
• Ensure that unit test coverage remains above 80%
• Update all applicable documentation
• Follow Cluster Toolkit Contribution guidelines #

[gemini-code-assist]

Summary of Changes

Hello @simrankaurb, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request establishes a new integration test to validate the deployment and functionality of A3 UltraGPU instances configured as JBVMs (Jumbo VMs) using Google Cloud's cost-effective Spot VM provisioning model. The changes involve adding the necessary Cloud Build and test definition files, along with dynamic adjustments to the VM blueprint to ensure compatibility with Spot instances.

Highlights

• New Integration Test: Introduces a new integration test specifically for A3 UltraGPU JBVMs utilizing Spot Virtual Machines.
• Cloud Build Configuration: Adds a new Cloud Build configuration file (ml-a3-ultragpu-onspot-jbvms.yaml) to orchestrate the execution of this new test.
• Test Definition: Includes a new test definition file (ml-a3-ultragpu-onspot-jbvms.yml) that configures the test parameters, explicitly setting the provisioning model to "SPOT".
• Blueprint Adjustments: Modifies the A3 UltraGPU blueprint within the Cloud Build process to remove "reservation" and "automatic_restart" settings, which are incompatible with Spot VMs, ensuring the test runs correctly.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request adds a new integration test for A3 UltraGPU instances using Spot VMs. The changes, which include a new Cloud Build configuration and a corresponding test definition file, are well-structured. I have one suggestion for the Cloud Build configuration to improve the robustness and maintainability of the script that modifies the test blueprint.