feat(storage): migrate ACL samples and tests

[angelcaamal]

Description

Fixes #

Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.

Checklist

• I have followed guidelines from CONTRIBUTING.MD and Samples Style Guide
• Tests pass: npm test (see Testing)
• Lint pass: npm run lint (see Style)
• Required CI tests pass (see CI testing)
• These samples need a new API enabled in testing projects to pass (let us know which ones)
• These samples need a new/updated env vars in testing projects set to pass (let us know which ones)
• This pull request is from a branch created directly off of GoogleCloudPlatform/nodejs-docs-samples. Not a fork.
• This sample adds a new sample directory, and I updated the CODEOWNERS file with the codeowners for this sample
• This sample adds a new sample directory, and I created GitHub Actions workflow for this sample
• This sample adds a new Product API, and I updated the Blunderbuss issue/PR auto-assigner with the codeowners for this sample
• Please merge this PR for me once it is approved

Note: Any check with (dev), (experimental), or (legacy) can be ignored and should not block your PR from merging (see CI testing).

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly enhances the Google Cloud Storage Node.js samples by providing a complete suite of examples for Access Control List (ACL) management. It enables developers to programmatically control permissions for buckets and files, covering operations like granting and revoking ownership, and retrieving current ACL configurations. The inclusion of dedicated system tests ensures the reliability and accuracy of these new ACL functionalities.

Highlights

• New ACL Samples: Introduced a comprehensive set of new Node.js samples for managing Access Control Lists (ACLs) on Google Cloud Storage buckets and files. These samples cover adding, removing, and printing ACL entries for various entities.
• Expanded Functionality: Added specific functionalities to manage default bucket owners, individual bucket owners, and file owners, allowing for fine-grained control over permissions.
• System Test Coverage: Implemented new system tests (acl.test.js) to thoroughly validate the correctness and reliability of all newly added ACL management samples.
• Infrastructure Updates: Updated project dependencies in package.json and added a cleanup script to manage test resources, ensuring a robust testing environment.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request adds a number of new Node.js samples for Google Cloud Storage ACL operations. The overall structure is good, but there is a critical race condition in all the new sample files: they call an async function without await from a synchronous main function, which can cause the script to exit prematurely. I've provided suggestions to fix this by making the main function async and simplifying the structure. I've also found some issues in the test and cleanup scripts, including redundant code and misleading test descriptions, and have suggested fixes for those as well.

[snippet-bot]

Here is the summary of changes.

You are about to add 10 region tags.

• storage/addBucketDefaultOwnerAcl.js:26, tag storage_add_bucket_default_owner
• storage/addBucketOwnerAcl.js:26, tag storage_add_bucket_owner
• storage/addFileOwnerAcl.js:30, tag storage_add_file_owner
• storage/printBucketAcl.js:26, tag storage_print_bucket_acl
• storage/printBucketAclForUser.js:26, tag storage_print_bucket_acl_for_user
• storage/printFileAcl.js:26, tag storage_print_file_acl
• storage/printFileAclForUser.js:30, tag storage_print_file_acl_for_user
• storage/removeBucketDefaultOwner.js:26, tag storage_remove_bucket_default_owner
• storage/removeBucketOwnerAcl.js:26, tag storage_remove_bucket_owner
• storage/removeFileOwnerAcl.js:30, tag storage_remove_file_owner

---

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

• Refresh this comment