Skip to content

Update code.js#1704

Open
lonix86 wants to merge 2 commits intoGoogleCloudPlatform:mainfrom
lonix86:patch-1
Open

Update code.js#1704
lonix86 wants to merge 2 commits intoGoogleCloudPlatform:mainfrom
lonix86:patch-1

Conversation

@lonix86
Copy link
Copy Markdown

@lonix86 lonix86 commented Jan 12, 2026

Refactor netblock storage and add recursive SPF resolution

  • Store all IP ranges in a single JSON script property to prevent IPv6 key corruption
  • Add recursive parsing of SPF include directives
  • Remove legacy per-IP property storage
  • Improve change detection reliability
  • Enhance email report formatting and readability

Refactor netblock storage and add recursive SPF resolution

- Store all IP ranges in a single JSON script property to prevent IPv6 key corruption
- Add recursive parsing of SPF include directives
- Remove legacy per-IP property storage
- Improve change detection reliability
- Enhance email report formatting and readability
@pull-request-size pull-request-size Bot added the size/XL Denotes a PR that changes 500-999 lines. label Jan 12, 2026
@google-cla
Copy link
Copy Markdown

google-cla Bot commented Jan 12, 2026

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@agold-rh
Copy link
Copy Markdown
Contributor

@lonix86 If you can get the CLA done, I can take a look at merging your PR. Without the CLA, my hands are tied.

@lonix86
Copy link
Copy Markdown
Author

lonix86 commented Jan 13, 2026 via email

.timeBased()
.everyDays(1)
.atHour(8)
.inTimezone('Europe/Rome')
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like DAILY_TRIGGER_TZ has been replaced by a specific hard coded zone. This doesn't feel right, but I could be mistaken.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lonix86 Do you mind taking a look at this?

Thank you!

@agold-rh
Copy link
Copy Markdown
Contributor

@jdw353 Do you mind taking a quick look at this PR? I know it's been forever, but you're the only previous contributor to this code, and I'd like a second pair of eyes on the apparent TZ change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/XL Denotes a PR that changes 500-999 lines.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants