nits: incorrect condition stmt for options.Excludes#1929
Merged
sergeylanzman merged 1 commit intoGoogleCloudPlatform:masterfrom Mar 26, 2025
Merged
Conversation
sergeylanzman
approved these changes
Mar 26, 2025
930ce5b
into
GoogleCloudPlatform:master
1 of 3 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In
cmd/import.go, there is an implementation that checks whetherExcludesoptions is specified.The default value for
options.Excludesis[]string{}as you can see here:terraformer/cmd/import.go
Lines 395 to 410 in a5b4b69
However, the condition statement for checking
options.Excludesisif options.Excludes != nil.terraformer/cmd/import.go
Line 127 in a5b4b69
As default value for
options.Excludesis[]string{}, this always results true.This should be fixed as
len(options.Excludes) > 0This does not cause panic when
option.Excludesis false as you can see hereYou can see similar implementation here:
terraformer/cmd/provider_cmd_aws.go
Line 53 in ceb25e2