Start modernizing Okta provider with Go SDK v5#1939
Merged
sergeylanzman merged 8 commits intoGoogleCloudPlatform:masterfrom Mar 26, 2025
Merged
Start modernizing Okta provider with Go SDK v5#1939sergeylanzman merged 8 commits intoGoogleCloudPlatform:masterfrom
sergeylanzman merged 8 commits intoGoogleCloudPlatform:masterfrom
Conversation
Signed-off-by: Brenno Oliveira <brenno.oliveira@deliveryhero.com>
cacarico
approved these changes
Oct 20, 2024
jgalluzzi
reviewed
Oct 21, 2024
jgalluzzi
left a comment
There was a problem hiding this comment.
Can the okta terraform provider be upgraded as well?
Contributor
Author
it should not be needed as the wrapper gets the version dynamically - I will double check |
Contributor
Author
|
yep it gets from your local, for example add this into a provider.tf provider "okta" {}
terraform {
required_providers {
okta = {
source = "okta/okta"
version = "~> 4.11.1"
}
}
}run |
Signed-off-by: Brenno Oliveira <brenno.oliveira@deliveryhero.com>
Contributor
Author
|
@sergeylanzman I'm waiting on your review to decide if I continue with this effort :) |
Signed-off-by: Brenno Oliveira <brenno.oliveira@deliveryhero.com>
Signed-off-by: Brenno Oliveira <brenno.oliveira@deliveryhero.com>
Signed-off-by: Brenno Oliveira <brenno.oliveira@deliveryhero.com>
Signed-off-by: Brenno Oliveira <brenno.oliveira@deliveryhero.com>
Signed-off-by: Brenno Oliveira <brenno.oliveira@deliveryhero.com>
480d5b2
into
GoogleCloudPlatform:master
2 of 4 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR modernizes the Okta provider by introducing the Okta Go SDK v5 while maintaining backward compatibility with the existing v2 SDK.
The following generators have been updated to use the v5 SDK:
New resources added:
Related to #1936
The code has been simplified by removing unnecessary type assertions and manual filtering, and the accuracy of the generated Terraform resources has been improved.
Further modernization of the remaining resources and the introduction of missing resources will be addressed in future PRs.