Skip to content

Merge tool installation rules in Makefile #2067

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
google-oss-prow merged 1 commit into from
Feb 23, 2026
Merged

Merge tool installation rules in Makefile #2067

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 7 additions & 16 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -485,12 +485,9 @@ clean-helm:
@rm -rf $(HELM_STAGING_DIR)
@rm -rf $(HELM)

"$(GOBIN)/kind":
# Build kind with CGO disabled so it can be used in containers without C installed.
CGO_ENABLED=0 go install sigs.k8s.io/kind

"$(KIND)": "$(GOBIN)/kind" buildenv-dirs
cp $(GOBIN)/kind $(KIND)
# Build kind with CGO disabled so it can be used in containers without C installed.
"$(KIND)": buildenv-dirs
GOPATH="$(GO_DIR)" CGO_ENABLED=0 go install sigs.k8s.io/kind

.PHONY: install-kind
# install kind (user-friendly target alias)
Expand All @@ -504,18 +501,12 @@ clean-go-junit-report:
# install go-junit-report (user-friendly target alias)
install-go-junit-report: "$(GO_JUNIT_REPORT)"

"$(GOBIN)/go-junit-report":
CGO_ENABLED=0 go install github.com/jstemmer/go-junit-report/v2

"$(GO_JUNIT_REPORT)": "$(GOBIN)/go-junit-report" buildenv-dirs
cp $(GOBIN)/go-junit-report $(GO_JUNIT_REPORT)
"$(GO_JUNIT_REPORT)": buildenv-dirs
GOPATH="$(GO_DIR)" CGO_ENABLED=0 go install github.com/jstemmer/go-junit-report/v2

# Set CGO_ENABLED=0 for compatibility with containers missing glibc
"$(GOBIN)/crane":
CGO_ENABLED=0 go install github.com/google/go-containerregistry/cmd/crane

"$(CRANE)": "$(GOBIN)/crane" buildenv-dirs
cp $(GOBIN)/crane $(CRANE)
"$(CRANE)": buildenv-dirs
GOPATH="$(GO_DIR)" CGO_ENABLED=0 go install github.com/google/go-containerregistry/cmd/crane

.PHONY: install-crane
# install crane (user-friendly target alias)
Expand Down