Add consolidated script to update component images#2096
Add consolidated script to update component images#2096Camila-B wants to merge 2 commits intoGoogleContainerTools:mainfrom
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces a new automated mechanism to keep the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request introduces a script and a corresponding Makefile target to automate the update process for the otelcontribcol image version. The script correctly handles two modes of operation: updating to the latest version and updating to the latest build of the current version. The overall approach is solid. I've provided a few suggestions to enhance the script's robustness by improving how it parses and modifies the Makefile, and to make its error reporting more user-friendly.
9696b1b to
96ae492
Compare
tiffanny29631
left a comment
There was a problem hiding this comment.
Great work on this. This script should make Louhi automation much easier too. The regex is a bit brittle, but we can iterate on that later as long as image naming stays consistent. Are there plans for pipeline integration? If so, please consider adding dry-run and quiet flags to improve CI/CD compatibility. Not necessary in this PR.
|
Thanks! I'll add dry-run and quiet flags in a separate PR |
update-<component>-image.shintoupdate-component-image.sh