Conversation
|
Thanks 🎉 Don't worry if you are not seeing Korean characters in the GUI, I just have to manually add them. |
| pub fn start_translation(language: Language) -> &'static str { | ||
| match language { | ||
| Language::EN | Language::DE | Language::RO => "Start!", | ||
| Language::EN | Language::DE | Language::RO | Language::KO => "Start!", |
There was a problem hiding this comment.
Is this correct to remain "start"?
There was a problem hiding this comment.
I left it because I thought it would look weird if I translate it.
It might be better to leave it as it is :)
src/translations/translations.rs
Outdated
| Puteți activa notificările din setări:", | ||
| Language::KO => "아직 알림을 활성화하지 않았습니다!\n\n\ | ||
| 활성화로 설정하면 이 페이지에 알림 로그가 표시됩니다\n\n\ | ||
| You can enable notifications from settings:", |
There was a problem hiding this comment.
I think you missed this translation as well
There was a problem hiding this comment.
opps. I missed the last sentence.
This sentence is "설정에서 알림을 활성화할 수 있습니다:" can be translated into
DocRAID
left a comment
DocRAID
left a comment
There was a problem hiding this comment.
I wasn't meticulous.
Thank you for finding my mistake 😄
| pub fn start_translation(language: Language) -> &'static str { | ||
| match language { | ||
| Language::EN | Language::DE | Language::RO => "Start!", | ||
| Language::EN | Language::DE | Language::RO | Language::KO => "Start!", |
There was a problem hiding this comment.
I left it because I thought it would look weird if I translate it.
It might be better to leave it as it is :)
src/translations/translations.rs
Outdated
| Puteți activa notificările din setări:", | ||
| Language::KO => "아직 알림을 활성화하지 않았습니다!\n\n\ | ||
| 활성화로 설정하면 이 페이지에 알림 로그가 표시됩니다\n\n\ | ||
| You can enable notifications from settings:", |
There was a problem hiding this comment.
opps. I missed the last sentence.
This sentence is "설정에서 알림을 활성화할 수 있습니다:" can be translated into
|
Amazing, thank you again 🎉 |
|
@all-contributors please add @DocRAID for translation. |
|
I've put up a pull request to add @DocRAID! 🎉 |
2 participants
No description provided.