Fixed build and packaging issues#246
Merged
GyulyVGC merged 12 commits intoGyulyVGC:packagesfrom Jun 7, 2023
4r7if3x:hotfix/build-packaging
Merged
Fixed build and packaging issues#246GyulyVGC merged 12 commits intoGyulyVGC:packagesfrom 4r7if3x:hotfix/build-packaging
GyulyVGC merged 12 commits intoGyulyVGC:packagesfrom
4r7if3x:hotfix/build-packaging
Conversation
GyulyVGC
reviewed
Jun 6, 2023
Owner
|
A more in depth review will come soon. Thank you so much for all the work! |
GyulyVGC
reviewed
Jun 6, 2023
GyulyVGC
reviewed
Jun 6, 2023
for localization compatibility
Owner
|
A little recap: I've reviewed part of the PR but still a considerable part is missing and I'll do it in the next few days. I've just opened a (still incomplete) issue to track all the missing steps related to packaging: #252 Since various problems are going to be solved by this PR, I'm looking forward to release a new version ASAP after merge (so don't worry to much about the other steps for the moment). Thanks very much again 👍 |
GyulyVGC
reviewed
Jun 7, 2023
GyulyVGC
reviewed
Jun 7, 2023
GyulyVGC
approved these changes
Jun 7, 2023
Owner
|
It'll be merged in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch addresses some cross-building and packaging issues, including: #47, #199, #220, #224, #225, #242, and rust-pcap/pcap#290.
Changes:
libssl.so*) and it utilizes therust-tlsinstead.resources/packaging/installs the Npcap automaticallydisplays a notice about the need for manual Npcap installation and opens its official website for the user.sudo.+ Some adjustments on PowerShell scripts, WXS template of WixToolset, info files, etc.
Hacks:
v0.8oflibpcap, the linker sets this version of the library (libpcap.so.0.8) as the dependency of the ELF executable. That won't work on Redhat-based distros as they usually come withv1.x. Therefore, I've changed it tolibpcap.somanually which is symlinked to the actual installed version.To-Do:
Since the app doesn't have an icon in the Windows taskbar, I've tried to set the icon on the window settings of Iced, but I had to comment it out since it made the executable not work after compiling. I'm already in discussion with the Iced community to find a solution...xprop WM_CLASS), hence theStartupWMClass=sniffnetthat I had set in the.desktopfile wouldn't work.Known Issues:
cargo bundlecommand carries out an unavoidable extra build since it doesn't come with a--no-buildflag, unlike other packaging tools. (already sent a feature request)Tests
Other than the minor issues mentioned above, both the installer and the app are tested on a fresh installation of Debian, Ubuntu, and Fedora Linux distros as well as macOS and Windows 11. Feedback from other testers is highly appreciated!
Screenshots:
Footnotes
macOS and Redhat-based Linux distros only support 64-bit CPUs, and since most Windows machines are using x86 CPU families, we only provide packages for them. ↩
Developers would need
build-essential libfreetype6-dev, libexpat1-dev, libpcap-dev, libasound2-dev, libfontconfig1-devpackages on Debian-based distros and@development-tools, expat-devel, libpcap-devel, alsa-lib-devel, fontconfig-develon Redhat-based distros in order to develop this app on Linux. But end users only require the non-development version of the dependencies:libpcap0.8, libasound2, libfontconfig1for Debiab-based distros andlibpcap, alsa-lib, fontconfigfor Redhat-based. ↩